github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Panic in RedisQueue on Terminate #4696

New Issue
Closed
opened 2025-11-02 05:59:51 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 05:59:51 -06:00
Owner
Copy Link

Originally created by @lunny on GitHub (Jan 21, 2020).

When set

[queue.task]
TYPE = redis
CONN_STR = "addrs=127.0.0.1:6379 db=0"

[queue.mail]
TYPE = redis
CONN_STR = "addrs=127.0.0.1:6379 db=0"

and then stop gitea

panic: close of nil channel

goroutine 63 [running]:
code.gitea.io/gitea/modules/queue.(*RedisQueue).Terminate(0xc00036b730)
	/Volumes/data/Projects/gitea/gitea/modules/queue/queue_redis.go:219 +0x153
code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate.func1(0xc00018a960, 0xc00044e400, 0x6d7e940, 0xc0000de008)
	/Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:126 +0x110
created by code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate
	/Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:123 +0x7a
panic: close of nil channel

goroutine 202 [running]:
code.gitea.io/gitea/modules/queue.(*RedisQueue).Terminate(0xc000148700)
	/Volumes/data/Projects/gitea/gitea/modules/queue/queue_redis.go:219 +0x153
code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate.func1(0xc00018a960, 0xc00198e700, 0x6d7e940, 0xc0000de008)
	/Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:126 +0x110
created by code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate
	/Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:123 +0x7a
Originally created by @lunny on GitHub (Jan 21, 2020). When set ```ini [queue.task] TYPE = redis CONN_STR = "addrs=127.0.0.1:6379 db=0" [queue.mail] TYPE = redis CONN_STR = "addrs=127.0.0.1:6379 db=0" ``` and then stop gitea ```log panic: close of nil channel goroutine 63 [running]: code.gitea.io/gitea/modules/queue.(*RedisQueue).Terminate(0xc00036b730) /Volumes/data/Projects/gitea/gitea/modules/queue/queue_redis.go:219 +0x153 code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate.func1(0xc00018a960, 0xc00044e400, 0x6d7e940, 0xc0000de008) /Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:126 +0x110 created by code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate /Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:123 +0x7a panic: close of nil channel goroutine 202 [running]: code.gitea.io/gitea/modules/queue.(*RedisQueue).Terminate(0xc000148700) /Volumes/data/Projects/gitea/gitea/modules/queue/queue_redis.go:219 +0x153 code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate.func1(0xc00018a960, 0xc00198e700, 0x6d7e940, 0xc0000de008) /Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:126 +0x110 created by code.gitea.io/gitea/modules/graceful.(*Manager).RunAtTerminate /Volumes/data/Projects/gitea/gitea/modules/graceful/manager.go:123 +0x7a ```
GiteaMirror added the skip-changelogtype/bug labels 2025-11-02 05:59:51 -06:00
GiteaMirror commented 2025-11-02 05:59:52 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Jan 21, 2020):

The terminated channel has been missed being created.

@zeripath commented on GitHub (Jan 21, 2020): The terminated channel has been missed being created.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label skip-changelog type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4696
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?