PR review comments are deleted after push. #4648

New Issue

GiteaMirror · 2025-11-02T05:57:37-06:00

GiteaMirror commented

2025-11-02 05:57:37 -06:00

Originally created by @airamrguez on GitHub (Jan 14, 2020).

Gitea version (or commit ref): 1.9.3
Git version: git version 2.21.0 (Apple Git-122.2)
Operating system: macOS Catalina
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Description

Steps to reproduce:

Make a PR.
Add some inline comments to any lines using the review UI.
Modify those lines in the code and push the changes.

What happens?

Review comments are deleted.

Originally created by @airamrguez on GitHub (Jan 14, 2020).  - Gitea version (or commit ref): 1.9.3 - Git version: git version 2.21.0 (Apple Git-122.2) - Operating system: macOS Catalina - Database (use `[x]`): - [ ] PostgreSQL - [X] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [X] No - [ ] Not relevant - Log gist: ## Description Steps to reproduce: 1. Make a PR. 2. Add some inline comments to any lines using the review UI. 3. Modify those lines in the code and push the changes. What happens? Review comments are deleted.

GiteaMirror closed this issue

2025-11-02 05:57:37 -06:00

GiteaMirror commented

2025-11-02 05:57:38 -06:00

@guillep2k commented on GitHub (Jan 14, 2020):

There has been a lot of work on comments since 1.9.3. Upgrading to 1.10.2 (latest stable) should get you some improvements, but if I recall correctly your problem may have been fixed recently in 1.11.0
(currently RC1). You can try on try.gitea.io (which has a slightly newer version than that) to see if you can reproduce the problem there.

@guillep2k commented on GitHub (Jan 14, 2020): There has been a lot of work on comments since 1.9.3. Upgrading to 1.10.2 (latest stable) should get you some improvements, but if I recall correctly your problem may have been fixed recently in 1.11.0 (currently RC1). You can try on [try.gitea.io](try.gitea.io) (which has a slightly newer version than that) to see if you can reproduce the problem there.

GiteaMirror commented

2025-11-02 05:57:38 -06:00

@airamrguez commented on GitHub (Jan 14, 2020):

@guillep2k thanks. We'll upgrade to 1.11.0 and try it again.

@airamrguez commented on GitHub (Jan 14, 2020): @guillep2k thanks. We'll upgrade to 1.11.0 and try it again.

GiteaMirror commented

2025-11-02 05:57:39 -06:00

@lcnittl commented on GitHub (Jan 14, 2020):

@guillep2k it is try.gitea.io, right?

@lcnittl commented on GitHub (Jan 14, 2020): @guillep2k it is [try.gitea.**io**](https://try.gitea.io), right?

GiteaMirror commented

2025-11-02 05:57:39 -06:00

@guillep2k commented on GitHub (Jan 14, 2020):

@guillep2k it is try.gitea.io, right?

Of course, thank you.

@guillep2k commented on GitHub (Jan 14, 2020): > > > @guillep2k it is [try.gitea.**io**](https://try.gitea.io), right? Of course, thank you.

GiteaMirror commented

2025-11-02 05:57:39 -06:00

@zeripath commented on GitHub (Jan 15, 2020):

Please note that just like here, when you write inline comments they are pending unless you press one of approve, comment, request changes

@zeripath commented on GitHub (Jan 15, 2020): Please note that just like here, when you write inline comments they are pending unless you press one of approve, comment, request changes

GiteaMirror commented

2025-11-02 05:57:39 -06:00

@airamrguez commented on GitHub (Feb 5, 2020):

I have upgraded Gitea to version 1.10.3, wrote some inline comments, then pressed "Request changes", then git push and after all that comments still disappear.

@airamrguez commented on GitHub (Feb 5, 2020): I have upgraded Gitea to version 1.10.3, wrote some inline comments, then pressed "Request changes", then git push and after all that comments still disappear.

GiteaMirror commented

2025-11-02 05:57:40 -06:00

@lunny commented on GitHub (Feb 5, 2020):

That comments maybe out of date so it cannot be displayed.

@lunny commented on GitHub (Feb 5, 2020): That comments maybe out of date so it cannot be displayed.

GiteaMirror commented

2025-11-02 05:57:40 -06:00

@airamrguez commented on GitHub (Feb 6, 2020):

@lunny We actively use Gitea in our team. We do code reviews every day so I suppose they cannot be out of date

@airamrguez commented on GitHub (Feb 6, 2020): @lunny We actively use Gitea in our team. We do code reviews every day so I suppose they cannot be out of date

GiteaMirror commented

2025-11-02 05:57:40 -06:00

@guillep2k commented on GitHub (Feb 6, 2020):

@airamrguez An outdated review is one that no longer matches a line of a PR code. For example, if you comment on line 80 of a file, but a later commit removes that particular line, then the review comment doesn't have a context for being displayed.

@guillep2k commented on GitHub (Feb 6, 2020): @airamrguez An outdated review is one that no longer matches a line of a PR code. For example, if you comment on line 80 of a file, but a later commit removes that particular line, then the review comment doesn't have a context for being displayed.

GiteaMirror commented

2025-11-02 05:57:40 -06:00

@airamrguez commented on GitHub (Feb 6, 2020):

@guillep2k this is what happening, but is this how it should be? I mean, I don't want to lose those comments.

@airamrguez commented on GitHub (Feb 6, 2020): @guillep2k this is what happening, but is this how it should be? I mean, I don't want to lose those comments.

GiteaMirror commented

2025-11-02 05:57:41 -06:00

@guillep2k commented on GitHub (Feb 6, 2020):

@airamrguez You are running Gitea 1.9.3. I think that your problem is currently solved, but I'm not certain about the right version (1.11 is release candidate now, and we're working in the 1.12 branch). This kind of review didn't generate a record in the comment table, but now they do.

What you can do:

Upgrade to the latest 1.10.x or 1.11.0 when it comes out. I believe the problem was fixed in the 1.11 branch. Make sure to download a three-numbered version (e.g. 1.10.3 or 1.11.0) which is a release and not a two-numbered version (1.10, 1.11) which is our repo's head to add modifications.
If the above doesn't solve your problem, check if you can still reproduce it in try.gitea.io, which has the latest unstable version of Gitea.

Please mind that old comments might be hidden forever; you need to create new comments.

@guillep2k commented on GitHub (Feb 6, 2020): @airamrguez You are running Gitea 1.9.3. I think that your problem is currently solved, but I'm not certain about the right version (1.11 is release candidate now, and we're working in the 1.12 branch). This kind of review didn't generate a record in the `comment` table, but now they do. What you can do: - Upgrade to the latest 1.10.x or 1.11.0 when it comes out. I believe the problem was fixed in the 1.11 branch. Make sure to download a three-numbered version (e.g. 1.10.3 or 1.11.0) which is a release and not a two-numbered version (1.10, 1.11) which is our repo's head to add modifications. - If the above doesn't solve your problem, check if you can still reproduce it in [try.gitea.io](https://try.gitea.io), which has the latest _unstable_ version of Gitea. Please mind that old comments might be hidden forever; you need to create new comments.

GiteaMirror commented

2025-11-02 05:57:41 -06:00

@airamrguez commented on GitHub (Feb 13, 2020):

@guillep2k We hace upgraded to version 1.11.0-rc2 and I think that comments are now preserved. It’s ok for me. Thank you all for your support

@airamrguez commented on GitHub (Feb 13, 2020): @guillep2k We hace upgraded to version 1.11.0-rc2 and I think that comments are now preserved. It’s ok for me. Thank you all for your support

GiteaMirror referenced this issue

2025-11-02 13:28:02 -06:00

[PR #4651] [MERGED] Hide home button when landing page is not set to home #17449

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#4648