github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

DeleteRepoFile incorrectly handles Delete to new branch #4642

New Issue
Closed
opened 2025-11-02 05:57:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 05:57:11 -06:00
Owner
Copy Link

Originally created by @zeripath on GitHub (Jan 13, 2020).

Whilst looking at #9708 I've noticed that there is an issue with:

1751d5fcf2/modules/repofiles/delete.go (L49)

This should be

if err != nil && !git.IsErrNotExist(err) {

however this breaks several tests which need to also be fixed.

Originally created by @zeripath on GitHub (Jan 13, 2020). Whilst looking at #9708 I've noticed that there is an issue with: https://github.com/go-gitea/gitea/blob/1751d5fcf200b7d78ec5543fa620174c69d2746a/modules/repofiles/delete.go#L49 This should be ```go if err != nil && !git.IsErrNotExist(err) { ``` however this breaks several tests which need to also be fixed.
GiteaMirror added the type/bug label 2025-11-02 05:57:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?