note: refacotr models/webhook.go #4624

New Issue

GiteaMirror · 2025-11-02T05:56:40-06:00

GiteaMirror commented

2025-11-02 05:56:40 -06:00

Originally created by @6543 on GitHub (Jan 10, 2020).

note for me:

refactor models/webhook.go to combine GetWebhooksByRepoID and GetWebhooksByOrgID to `GetWebhooks(opts SearchWebhooksOptions) .,...

// SearchWebhooksOptions holds the search options
type SearchWebhooksOptions struct {
...

Originally created by @6543 on GitHub (Jan 10, 2020). note for me: refactor models/webhook.go to combine GetWebhooksByRepoID and GetWebhooksByOrgID to `GetWebhooks(opts SearchWebhooksOptions) .,... ``` // SearchWebhooksOptions holds the search options type SearchWebhooksOptions struct { ... ```

GiteaMirror added the issue/confirmed type/proposal labels 2025-11-02 05:56:40 -06:00

GiteaMirror closed this issue

2025-11-02 05:56:40 -06:00

GiteaMirror commented

2025-11-02 05:56:41 -06:00

@6543 commented on GitHub (Jan 10, 2020):

@SpaWn2KiLl ping

@6543 commented on GitHub (Jan 10, 2020): @SpaWn2KiLl ping

GiteaMirror commented

2025-11-02 05:56:41 -06:00

@6543 commented on GitHub (Jan 10, 2020):

and we can also include GetActiveWebhooksByOrgID

@6543 commented on GitHub (Jan 10, 2020): and we can also include **GetActiveWebhooksByOrgID**

GiteaMirror commented

2025-11-02 05:56:41 -06:00

@hilariocoelho commented on GitHub (Jan 10, 2020):

I'll take this. If you find any more cases like this add to this issue please.

@hilariocoelho commented on GitHub (Jan 10, 2020): I'll take this. If you find any more cases like this add to this issue please.

GiteaMirror commented

2025-11-02 05:56:41 -06:00

@stale[bot] commented on GitHub (Mar 10, 2020):

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale[bot] commented on GitHub (Mar 10, 2020): This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:56:41 -06:00

@6543 commented on GitHub (Mar 11, 2020):

@SpaWn2KiLl are you still interested in it?

@6543 commented on GitHub (Mar 11, 2020): @SpaWn2KiLl are you still interested in it?

GiteaMirror commented

2025-11-02 05:56:42 -06:00

@alexanderadam commented on GitHub (Mar 12, 2020):

I'm not sure whether this could be related but it would be great if it would be made with focus on #1089, if someone decides to refactor models/webhook.go.

@alexanderadam commented on GitHub (Mar 12, 2020): I'm not sure whether this could be related but it would be great if it would be made with focus on #1089, if someone decides to refactor `models/webhook.go`.

GiteaMirror commented

2025-11-02 05:56:42 -06:00

@6543 commented on GitHub (Mar 13, 2020):

@alexanderadam this is out of scope ...

@6543 commented on GitHub (Mar 13, 2020): @alexanderadam this is out of scope ...

GiteaMirror commented

2025-11-02 05:56:42 -06:00

@alexanderadam commented on GitHub (Mar 14, 2020):

Okay, no problem 👍 I just wanted to mention it, in case it would be suitable.

@alexanderadam commented on GitHub (Mar 14, 2020): Okay, no problem :+1: I just wanted to mention it, in case it would be suitable.

GiteaMirror commented

2025-11-02 05:56:42 -06:00

@6543 commented on GitHub (Sep 17, 2020):

Did have a closer look into codebase: combining would have only minimal dedublication and would add complxity so this wont happen for now

@6543 commented on GitHub (Sep 17, 2020): Did have a closer look into codebase: combining would have only minimal dedublication and would add complxity so this wont happen for now

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#4624