Sometimes Ctrl+C cannot stop gitea #4505

Closed
opened 2025-11-02 05:52:54 -06:00 by GiteaMirror · 6 comments
Owner

Originally created by @lunny on GitHub (Dec 18, 2019).

macOS

图片
Originally created by @lunny on GitHub (Dec 18, 2019). macOS <img width="1178" alt="图片" src="https://user-images.githubusercontent.com/81045/71050631-aa9a7080-2180-11ea-8bf1-6948dfe37f01.png">
GiteaMirror added the type/bug label 2025-11-02 05:52:54 -06:00
Author
Owner

@bagasme commented on GitHub (Dec 18, 2019):

Have tried killing Gitea process?

@bagasme commented on GitHub (Dec 18, 2019): Have tried killing Gitea process?
Author
Owner

@zeripath commented on GitHub (Dec 18, 2019):

So since graceful took over the handle signals with a lifecycle there are a few places which may need to pay attention to shutdown and stop too - I've noticed the dB initialisation code needs to pay attention.

The fundamental is cause is likely that the waitGroups are not being emptied - thus web won't finish.

I'll take a look.

@zeripath commented on GitHub (Dec 18, 2019): So since graceful took over the handle signals with a lifecycle there are a few places which may need to pay attention to shutdown and stop too - I've noticed the dB initialisation code needs to pay attention. The fundamental is cause is likely that the waitGroups are not being emptied - thus web won't finish. I'll take a look.
Author
Owner

@zeripath commented on GitHub (Dec 23, 2019):

OK I noticed that things waiting on the issue indexer won't shutdown nicely because the holder doesn't listen to shutdown - that's fixed in #9363. #9313 removed the equivalent problem from the repo holder but, introduced other bugs which should be fixed by: #9476

@zeripath commented on GitHub (Dec 23, 2019): OK I noticed that things waiting on the issue indexer won't shutdown nicely because the holder doesn't listen to shutdown - that's fixed in #9363. #9313 removed the equivalent problem from the repo holder but, introduced other bugs which should be fixed by: #9476
Author
Owner

@guillep2k commented on GitHub (Jan 8, 2020):

@zeripath is this issue still pending?

@guillep2k commented on GitHub (Jan 8, 2020): @zeripath is this issue still pending?
Author
Owner

@lunny commented on GitHub (Jan 8, 2020):

Let's close now.

@lunny commented on GitHub (Jan 8, 2020): Let's close now.
Author
Owner

@zeripath commented on GitHub (Jan 8, 2020):

There's probably other places but we can reopen when they become apparent

@zeripath commented on GitHub (Jan 8, 2020): There's probably other places but we can reopen when they become apparent
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4505