Get issue comments API didn't return review details #4482

New Issue

GiteaMirror · 2025-11-02T05:52:14-06:00

GiteaMirror commented

2025-11-02 05:52:14 -06:00

Originally created by @NepPure on GitHub (Dec 13, 2019).

Gitea version (or commit ref):1.10.0
Git version:
Operating system:
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes https://try.gitea.io/api/v1/repos/oyyzowen/test2/issues/5/comments
- No
- Not relevant
Log gist:

Description

Test PR https://try.gitea.io/oyyzowen/test2/pulls/5?lang=en-US

API:/repos/{owner}/{repo}/issues/{index}/comments don't work as expected.

Screenshots

Originally created by @NepPure on GitHub (Dec 13, 2019).   - Gitea version (or commit ref):1.10.0 - Git version: - Operating system: - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes https://try.gitea.io/api/v1/repos/oyyzowen/test2/issues/5/comments - [ ] No - [ ] Not relevant - Log gist: ## Description Test PR https://try.gitea.io/oyyzowen/test2/pulls/5?lang=en-US API:`/repos/{owner}/{repo}/issues/{index}/comments` don't work as expected. ## Screenshots  ![image](https://user-images.githubusercontent.com/12379907/70785198-19647c00-1dc5-11ea-9634-9b4781e4dc10.png) ![image](https://user-images.githubusercontent.com/12379907/70785221-22ede400-1dc5-11ea-8ded-c536c9ac8a05.png)

GiteaMirror added the issue/confirmed type/enhancement labels 2025-11-02 05:52:15 -06:00

GiteaMirror commented

2025-11-02 05:52:15 -06:00

@NepPure commented on GitHub (Dec 17, 2019):

59fc29db38/routers/api/v1/repo/issue_comment.go (L64)

Include CommentTypeCode, add a new API, or add a parameter for comment type filtering?
Which solution would be better?

@NepPure commented on GitHub (Dec 17, 2019): https://github.com/go-gitea/gitea/blob/59fc29db383142586b6ac5cab7b324f16553e561/routers/api/v1/repo/issue_comment.go#L64 Include `CommentTypeCode`, add a new API, or add a parameter for comment type filtering? Which solution would be better?

GiteaMirror commented

2025-11-02 05:52:15 -06:00

@lunny commented on GitHub (Dec 17, 2019):

Maybe github could give use some idea.

@lunny commented on GitHub (Dec 17, 2019): Maybe github could give use some idea.

GiteaMirror commented

2025-11-02 05:52:15 -06:00

@NepPure commented on GitHub (Dec 17, 2019):

https://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request

Github has a separate set of APIs for pull request.
We can get review details from https://api.github.com/repos/go-gitea/gitea/pulls/9274/comments

@NepPure commented on GitHub (Dec 17, 2019): https://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request Github has a separate set of APIs for pull request. We can get review details from https://api.github.com/repos/go-gitea/gitea/pulls/9274/comments

GiteaMirror commented

2025-11-02 05:52:16 -06:00

@stale[bot] commented on GitHub (Feb 15, 2020):

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale[bot] commented on GitHub (Feb 15, 2020): This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#4482