Hide old Reactions wich are no longer Allowed #4461

Closed
opened 2025-11-02 05:51:40 -06:00 by GiteaMirror · 9 comments
Owner

Originally created by @6543 on GitHub (Dec 7, 2019).

This issue colect options of the gitea communety about title topic

Originally created by @6543 on GitHub (Dec 7, 2019). This issue colect options of the gitea communety about title topic
GiteaMirror added the type/enhancement label 2025-11-02 05:51:40 -06:00
Author
Owner

@guillep2k commented on GitHub (Dec 7, 2019):

IMHO the only reason to remove a reaction type is because it's causing problems. So, the reaction itself should disappear from the history if that's the case. Having said that, I don't like that idea; I'd rather let the admin have some moderating tools to manage that, but we don't want Gitea to become a social network (and it's a lot of work to do that properly), so... Tough choice.

@guillep2k commented on GitHub (Dec 7, 2019): IMHO the only reason to remove a reaction type is because it's causing problems. So, the reaction itself should disappear from the history if that's the case. Having said that, I don't like that idea; I'd rather let the admin have some moderating tools to manage that, but we don't want Gitea to become a social network (and it's a lot of work to do that properly), so... Tough choice.
Author
Owner

@jolheiser commented on GitHub (Dec 8, 2019):

I think if possible it'd be better to leave the DB intact and just not display it.
Then, if an admin decides to revert it later (or it was a mistake in the first place) they will display again.

@jolheiser commented on GitHub (Dec 8, 2019): I think if possible it'd be better to leave the DB intact and just not display it. Then, if an admin decides to revert it later (or it was a mistake in the first place) they will display again.
Author
Owner

@6543 commented on GitHub (Dec 8, 2019):

I created an poll: :D

EDIT: poll freezed after 9days ... stats:

Poll at 2019-12-17 16-16-33

@6543 commented on GitHub (Dec 8, 2019): I created an poll: :D EDIT: poll freezed after 9days ... stats: ![Poll at 2019-12-17 16-16-33](https://user-images.githubusercontent.com/24977596/71008346-bf2b2a00-20e8-11ea-9656-d06c70dfdd92.png)
Author
Owner

@6543 commented on GitHub (Dec 8, 2019):

My opinion is: still let old reaction untoched but only allow deletion if not alowed one ...
If a reaction is realy so harmfull a DELETE FROM reaction WHERE Type like "harmefull" can solve that problem ...

@6543 commented on GitHub (Dec 8, 2019): My opinion is: still let old reaction untoched but only allow deletion if not alowed one ... If a reaction is **realy** so harmfull a `DELETE FROM reaction WHERE Type like "harmefull"` can solve that problem ...
Author
Owner

@6543 commented on GitHub (Dec 9, 2019):

@go-gitea/maintainers poll your option if you have not ... and then wee will see :)

@6543 commented on GitHub (Dec 9, 2019): @go-gitea/maintainers poll your option if you have not ... and then wee will see :)
Author
Owner

@6543 commented on GitHub (Dec 9, 2019):

The poll is clear about this ... I'll send a PR

EDIT: not now ... still ongoing discusion

@6543 commented on GitHub (Dec 9, 2019): The poll is clear about this ... I'll send a PR EDIT: not now ... still ongoing discusion
Author
Owner

@lunny commented on GitHub (Dec 11, 2019):

We should have a more accurate meaning about the config.

; All available reactions. Allow users react with different emoji's
: For the whole list look at https://gitea.com/gitea/gitea.com/issues/8
REACTIONS = +1, -1, laugh, hooray, confused, heart, rocket, eyes

There are two meaning about REACTIONS. One is what reactions you will see, another is what reactions you can use. Most of the time they are the same. But when you change it serval times, it will not.

Or maybe we should have two options here. :)

@lunny commented on GitHub (Dec 11, 2019): We should have a more accurate meaning about the config. ``` ; All available reactions. Allow users react with different emoji's : For the whole list look at https://gitea.com/gitea/gitea.com/issues/8 REACTIONS = +1, -1, laugh, hooray, confused, heart, rocket, eyes ``` There are two meaning about `REACTIONS`. One is what reactions you will see, another is what reactions you can use. Most of the time they are the same. But when you change it serval times, it will not. Or maybe we should have two options here. :)
Author
Owner

@6543 commented on GitHub (Dec 17, 2019):

@lunny about secound setting option:

  • think this will be rare used
  • can iretate ...
@6543 commented on GitHub (Dec 17, 2019): @lunny about secound setting option: - think this will be rare used - can iretate ...
Author
Owner

@6543 commented on GitHub (Dec 17, 2019):

PR is here: #9387

@6543 commented on GitHub (Dec 17, 2019): PR is here: #9387
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4461