github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 04:42:51 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

NoReply Address Always Dummy Address Regardless of Root URL Domain #4456

New Issue
Closed
opened 2025-11-02 05:51:31 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-02 05:51:31 -06:00
Owner
Copy Link

Originally created by @bagasme on GitHub (Dec 7, 2019).

  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.17.1
  • Operating system: Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
    (not relevant)

Description

Installing Gitea set NO_REPLY_ADDRESS option on app.ini to dummy noreply@example.org address, regardless of domain in ROOT_URL. For NoReply emails to function correctly, use address from same domain as in ROOT_URL. For example, if ROOT_URL domain is mygitea.instance, NO_REPLY_ADDRESS should be noreply@mygitea.instance.

Screenshots

(not relevant)

Originally created by @bagasme on GitHub (Dec 7, 2019). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 1.9.0 - Git version: 2.17.1 - Operating system: Ubuntu 18.04 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: (not relevant) ## Description Installing Gitea set `NO_REPLY_ADDRESS` option on `app.ini` to dummy `noreply@example.org` address, regardless of domain in `ROOT_URL`. For NoReply emails to function correctly, use address from same domain as in `ROOT_URL`. For example, if `ROOT_URL` domain is `mygitea.instance`, `NO_REPLY_ADDRESS` should be `noreply@mygitea.instance`. ## Screenshots (not relevant) <!-- **If this issue involves the Web Interface, please include a screenshot** -->
GiteaMirror added the type/docs label 2025-11-02 05:51:31 -06:00
GiteaMirror commented 2025-11-02 05:51:31 -06:00
Author
Owner
Copy Link

@bagasme commented on GitHub (Dec 10, 2019):

@lunny I think kind/docs label isn't appropriate here, as this issue is about configuration.

@bagasme commented on GitHub (Dec 10, 2019): @lunny I think `kind/docs` label isn't appropriate here, as this issue is about configuration.
GiteaMirror commented 2025-11-02 05:51:32 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Dec 11, 2019):

If I understand you correctly You mean to say that on this line:

01a4a7cb14/modules/setting/service.go (L86)

You think the default should be:

Service.NoReplyAddress = sec.Key("NO_REPLY_ADDRESS").MustString(Domain)

You would need to update:

ee7df7ba8c/custom/conf/app.ini.sample (L507)

NO_REPLY_ADDRESS = %(DOMAIN)s

And it would be helpful to add a description in to https://github.com/go-gitea/gitea/blob/master/docs/content/doc/advanced/config-cheat-sheet.en-us.md#service-service as this option is not documented there.

@zeripath commented on GitHub (Dec 11, 2019): If I understand you correctly You mean to say that on this line: https://github.com/go-gitea/gitea/blob/01a4a7cb14b3a48f9e8115d5bc93af7ae17f1275/modules/setting/service.go#L86 You think the default should be: ```go Service.NoReplyAddress = sec.Key("NO_REPLY_ADDRESS").MustString(Domain) ``` You would need to update: https://github.com/go-gitea/gitea/blob/ee7df7ba8c5e6a4b32b0c4048d2b535d8df3cbe9/custom/conf/app.ini.sample#L507 ```ini NO_REPLY_ADDRESS = %(DOMAIN)s ``` And it would be helpful to add a description in to https://github.com/go-gitea/gitea/blob/master/docs/content/doc/advanced/config-cheat-sheet.en-us.md#service-service as this option is not documented there.
GiteaMirror commented 2025-11-02 05:51:32 -06:00
Author
Owner
Copy Link

@bagasme commented on GitHub (Dec 11, 2019):

@zeripath what's purpose of %(DOMAIN)s?

@bagasme commented on GitHub (Dec 11, 2019): @zeripath what's purpose of `%(DOMAIN)s`?
GiteaMirror commented 2025-11-02 05:51:32 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Dec 11, 2019):

It's just to document that the default value is the string value of DOMAIN

@zeripath commented on GitHub (Dec 11, 2019): It's just to document that the default value is the string value of DOMAIN
GiteaMirror commented 2025-11-02 05:51:32 -06:00
Author
Owner
Copy Link

@bagasme commented on GitHub (Dec 11, 2019):

OK, but I'd like to assign this issue to someone else instead. I'm just contributing to Gitea by reporting issues (currently).

@bagasme commented on GitHub (Dec 11, 2019): OK, but I'd like to assign this issue to someone else instead. I'm just contributing to Gitea by reporting issues (currently).
GiteaMirror commented 2025-11-02 05:51:32 -06:00
Author
Owner
Copy Link

@bagasme commented on GitHub (Dec 13, 2019):

@zeripath thanks for the PR

@bagasme commented on GitHub (Dec 13, 2019): @zeripath thanks for the PR
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/docs
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4456
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?