github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 04:42:51 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Keep preferences when submitting comment #4454

New Issue
Closed
opened 2025-11-02 05:51:28 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 05:51:28 -06:00
Owner
Copy Link

Originally created by @wgevaert on GitHub (Dec 6, 2019).

  • Gitea version (or commit ref): 1.9.4
  • Git version: Not relevant
  • Operating system: Not relevant

Description

I am reviewing a big feature, using the option to ignore all whitespace changes. When I then make a comment, the whitespace preferences are discarded. (Probably because of the #issuecomment-<number> part in the url)
When I then again set my whitespace preferences, I am no longer automatically moved to the comment I just made. Hence, I have two feature requests:

  • When making a comment, your whitespace & splitscreen preferences should not be discarted.
  • When changing your preferences, you want to be moved to the comment in your URL.

I think this can be fixed by changing the comment movement parameter to a GET-variable, but I am not sure if this is indeed possible (I do not know any GO).

Originally created by @wgevaert on GitHub (Dec 6, 2019). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 1.9.4 - Git version: Not relevant - Operating system: Not relevant ## Description I am reviewing a big feature, using the option to ignore all whitespace changes. When I then make a comment, the whitespace preferences are discarded. (Probably because of the `#issuecomment-<number>` part in the url) When I then again set my whitespace preferences, I am no longer automatically moved to the comment I just made. Hence, I have two feature requests: - When making a comment, your whitespace & splitscreen preferences should not be discarted. - When changing your preferences, you want to be moved to the comment in your URL. I think this can be fixed by changing the comment movement parameter to a GET-variable, but I am not sure if this is indeed possible (I do not know any GO).
GiteaMirror added the topic/prtopic/uitype/proposal labels 2025-11-02 05:51:28 -06:00
GiteaMirror commented 2025-11-02 05:51:29 -06:00
Author
Owner
Copy Link

@mnazarov commented on GitHub (Mar 4, 2021):

I think it can also be considered as a bug, because in some cases when the whitespace setting is reset after pressing 'add commit' the page can't restore the reading position with the anchor link (I guess because it shows different lines then before)

related report: https://github.com/go-gitea/gitea/issues/13758

@mnazarov commented on GitHub (Mar 4, 2021): I think it can also be considered as a bug, because in some cases when the whitespace setting is reset after pressing 'add commit' the page can't restore the reading position with the anchor link (I guess because it shows different lines then before) related report: https://github.com/go-gitea/gitea/issues/13758
GiteaMirror commented 2025-11-02 05:51:29 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Apr 25, 2023):

It has been fixed by https://github.com/go-gitea/gitea/pull/15566

@wxiaoguang commented on GitHub (Apr 25, 2023): It has been fixed by https://github.com/go-gitea/gitea/pull/15566
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label topic/pr topic/ui type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4454
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?