github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-16 13:13:23 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Automatically invalidate PR approvals in case of new commits #4331

New Issue
Closed
opened 2025-11-02 05:46:36 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 05:46:36 -06:00
Owner
Copy Link

Originally created by @manuelmohr on GitHub (Nov 15, 2019).

  • Gitea version (or commit ref): 1.10.0
  • Git version: 2.17.1
  • Operating system: Ubuntu 18.04.3 LTS
  • Can you reproduce the bug at https://try.gitea.io:
    • Not relevant

Description

Once a pull request has been approved, additional commits can be added to the pull request (potentially completely changing the proposed change) but the approving review stays valid.

While this makes it easy to sneak in minor fixes after a review without going through another review round, for some projects this poses an unacceptable risk.

Example:

  • Junior developer creates PR.
  • Senior developer reviews and approves.
  • Junior developer adds another "innocent" commit that actually introduces a bug.
  • Pull request is merged as it has an approving review.
  • There's now a bug in the software.

I propose to add an option in the style of Github (see below) to enable automatic invalidation of approvals as soon as the PR is changed.

Screenshots

image

Originally created by @manuelmohr on GitHub (Nov 15, 2019). - Gitea version (or commit ref): 1.10.0 - Git version: 2.17.1 - Operating system: Ubuntu 18.04.3 LTS - Can you reproduce the bug at https://try.gitea.io: - [x] Not relevant ## Description Once a pull request has been approved, additional commits can be added to the pull request (potentially completely changing the proposed change) **but the approving review stays valid**. While this makes it easy to sneak in minor fixes after a review without going through another review round, for some projects this poses an unacceptable risk. Example: - Junior developer creates PR. - Senior developer reviews and approves. - Junior developer adds another "innocent" commit that actually introduces a bug. - Pull request is merged as it has an approving review. - There's now a bug in the software. I propose to add an option in the style of Github (see below) to enable automatic invalidation of approvals as soon as the PR is changed. ## Screenshots ![image](https://user-images.githubusercontent.com/3143777/68927030-24f16280-0787-11ea-969c-d75d01d56d23.png)
GiteaMirror added the issue/duplicate label 2025-11-02 05:46:36 -06:00
GiteaMirror commented 2025-11-02 05:46:37 -06:00
Author
Owner
Copy Link

@davidsvantesson commented on GitHub (Nov 15, 2019):

Duplicate of #5997.

@davidsvantesson commented on GitHub (Nov 15, 2019): Duplicate of #5997.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?