[Permission Management] Support rights per member in a Organization Team and Introduce a Owner side-role (maintainer). #4330

New Issue

GiteaMirror · 2025-11-02T05:46:34-06:00

GiteaMirror commented

2025-11-02 05:46:34 -06:00

Originally created by @Cellebyte on GitHub (Nov 15, 2019).

Gitea version (or commit ref):
Git version:
Operating system:
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Description

Admin team member should be able to add and remove collaborators to teams attached to their admin team.
Every team which is added to this team tab can be edited by the members of the admin team.

Currently only the Owner can edit teams

...

Screenshots

Originally created by @Cellebyte on GitHub (Nov 15, 2019).   - Gitea version (or commit ref): - Git version: - Operating system: - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [X] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [X] Not relevant - Log gist: ## Description Admin team member should be able to add and remove collaborators to teams attached to their admin team. Every team which is added to this team tab can be edited by the members of the admin team. Currently only the Owner can edit teams ... ## Screenshots ![Screenshot from 2019-11-15 09-00-49](https://user-images.githubusercontent.com/16540824/68927253-9cbf8d00-0787-11ea-8ed6-b75025f58d79.png)

GiteaMirror added the type/proposal label 2025-11-02 05:46:34 -06:00

GiteaMirror commented

2025-11-02 05:46:35 -06:00

@davidsvantesson commented on GitHub (Nov 15, 2019):

I think team maintainers is a better idea. A team maintainer has same access as other team members but is allowed to add and remove team members. The maintainer can remove team repositories and add repositories he is admin of.

@davidsvantesson commented on GitHub (Nov 15, 2019): I think team maintainers is a better idea. A team maintainer has same access as other team members but is allowed to add and remove team members. The maintainer can remove team repositories and add repositories he is admin of.

GiteaMirror commented

2025-11-02 05:46:35 -06:00

@Cellebyte commented on GitHub (Nov 15, 2019):

@davidsvantesson is their currently an option for team maintainers?
I think a team maintainer and an admin team member are mostly the same persons. Because the admin team permissions allow editing collaborators in the repositories attached to the team I thought that adding teams to be edited by the admin team is the same behavior.

Introducing a new role only for editing teams is not correct. I think the Team concept should be edited to not only support one Permission. I want to add contributors with different permissions
to a team (read, write, admin/maintainer). (keep it simple.)

Example Team
- Contributor one (read)
- Contributor two (write)
- Contributor three (write)
- Contributor four (maintainer)
- Repositories
  - one
  - two
  - three

@Cellebyte commented on GitHub (Nov 15, 2019): @davidsvantesson is their currently an option for team maintainers? I think a team maintainer and an admin team member are mostly the same persons. Because the admin team permissions allow editing collaborators in the repositories attached to the team I thought that adding teams to be edited by the admin team is the same behavior. Introducing a new role only for editing teams is not correct. I think the Team concept should be edited to not only support one Permission. I want to add contributors with different permissions to a team (read, write, admin/maintainer). (keep it simple.) * Example Team * Contributor one (read) * Contributor two (write) * Contributor three (write) * Contributor four (maintainer) * Repositories * one * two * three

GiteaMirror commented

2025-11-02 05:46:35 -06:00

@davidsvantesson commented on GitHub (Nov 15, 2019):

@Cellebyte If I understand you correctly you want to add teams to teams. IMHO that just adds confusion and also complexity to code (need a new db table). Github uses maintainer role for teams.

I think there can be need for a "organization maintainer" role as well (could be added as a global org role or team permission) but that would give access to edit all teams and repositories (it would only limit some very sensitive operations like repository deletion).

@davidsvantesson commented on GitHub (Nov 15, 2019): @Cellebyte If I understand you correctly you want to add teams to teams. IMHO that just adds confusion and also complexity to code (need a new db table). Github uses maintainer role for teams. I think there can be need for a "organization maintainer" role as well (could be added as a global org role or team permission) but that would give access to edit all teams and repositories (it would only limit some very sensitive operations like repository deletion).

GiteaMirror commented

2025-11-02 05:46:35 -06:00

@lunny commented on GitHub (Nov 16, 2019):

@davidsvantesson Team maintainer concept is interesting. What's the difference between organization maintainer and Owners Team?

@lunny commented on GitHub (Nov 16, 2019): @davidsvantesson Team maintainer concept is interesting. What's the difference between `organization maintainer` and `Owners Team`?

GiteaMirror commented

2025-11-02 05:46:35 -06:00

@Cellebyte commented on GitHub (Nov 16, 2019):

@davidsvantesson No I said that a global Maintainer is not worth implementing. I think implementing the concept I have mentioned in my previous post is the way to go.

Add support for a Team to assign different roles on a team member basis.
The stacking of Teams (supported by github) is not the way to go. It is too complex. If you need that you can create different organizations which also serves your need at the moment.

@lunny

I think supporting a Maintainer Role inside the Owner Team is a good first approach. This comes handy in implementing member roles per team.

I think users in a team should be assigned different roles.
Some users only need read, write or maintainer access on a variety of repositories.
Also every role in a team must be stacked. So if I have admin/maintainer access I do not need write access separately.

A Maintainer only manages teams and permissions and cannot create repositories?

@Cellebyte commented on GitHub (Nov 16, 2019): @davidsvantesson No I said that a global Maintainer is not worth implementing. I think implementing the concept I have mentioned in my previous post is the way to go. Add support for a Team to assign different roles on a team member basis. The stacking of Teams (supported by github) is not the way to go. It is too complex. If you need that you can create different organizations which also serves your need at the moment. @lunny I think supporting a Maintainer Role inside the Owner Team is a good first approach. This comes handy in implementing member roles per team. I think users in a team should be assigned different roles. Some users only need read, write or maintainer access on a variety of repositories. Also every role in a team must be stacked. So if I have admin/maintainer access I do not need write access separately. A Maintainer only manages teams and permissions and cannot create repositories?

GiteaMirror commented

2025-11-02 05:46:36 -06:00

@bestlinuxgamers commented on GitHub (May 19, 2021):

@davidsvantesson Team maintainer concept is interesting. What's the difference between organization maintainer and Owners Team?

@lunny I would say that team maintainers are only allowed to edit the users of a specific team and are not allowed to edit the permissions of the team.

@bestlinuxgamers commented on GitHub (May 19, 2021): > @davidsvantesson Team maintainer concept is interesting. What's the difference between `organization maintainer` and `Owners Team`? @lunny I would say that team maintainers are only allowed to edit the users of a specific team and are not allowed to edit the permissions of the team.

GiteaMirror referenced this issue

2025-11-02 12:32:52 -06:00

[PR #4330] [MERGED] Add scope to Gitlab oauth request #17335

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#4330