Minify semantic.dropdown.custom.js #4306

New Issue

GiteaMirror · 2025-11-02T05:45:23-06:00

GiteaMirror commented

2025-11-02 05:45:23 -06:00

Originally created by @guillep2k on GitHub (Nov 13, 2019).

Thanks to #8598 now /js/index.js minified (58KB👍). However, /js/semantic.dropdown.custom.js (141KB) is still not (it's not a vendored library).

Originally created by @guillep2k on GitHub (Nov 13, 2019). Thanks to #8598 now `/js/index.js` minified (58KB👍). However, `/js/semantic.dropdown.custom.js` (141KB) is still not (it's not a vendored library).

GiteaMirror added the type/enhancement label 2025-11-02 05:45:23 -06:00

GiteaMirror closed this issue

2025-11-02 05:45:23 -06:00

GiteaMirror commented

2025-11-02 05:45:24 -06:00

@silverwind commented on GitHub (Nov 13, 2019):

We can import from index.js so it will be put in the main bundle. I'm working on a PR that will enable us to use import syntax and other modern JS features.

edit: https://github.com/go-gitea/gitea/pull/8973

@silverwind commented on GitHub (Nov 13, 2019): We can import from `index.js` so it will be put in the main bundle. I'm working on a PR that will enable us to use `import` syntax and other modern JS features. edit: https://github.com/go-gitea/gitea/pull/8973

GiteaMirror commented

2025-11-02 05:45:24 -06:00

@lunny commented on GitHub (Nov 14, 2019):

I also send a #8975 to allow us pack serval js to index.js.

@lunny commented on GitHub (Nov 14, 2019): I also send a #8975 to allow us pack serval js to index.js.

GiteaMirror commented

2025-11-02 05:45:25 -06:00

@silverwind commented on GitHub (Nov 18, 2019):

@Jookia is there some way to verify whether the customization from https://github.com/go-gitea/gitea/pull/8638 works? For example on https://try.gitea.io/repo/create, I don't see any aria-* attributes on the dropdown HTML. Is it already broken?

<div class="ui selection owner dropdown" tabindex="0">
  <input type="hidden" id="uid" name="uid" value="476" required="">
  <span class="text" title="silverwind"><img class="ui mini image" src="/user/avatar/silverwind/-1">
      silverwind</span>
  <i class="dropdown icon" tabindex="0"><div class="menu" tabindex="-1"></div></i>
  <div class="menu" tabindex="-1">
    <div class="item active selected" data-value="476" title="silverwind" tabindex="-1">
      <img class="ui mini image" src="/user/avatar/silverwind/-1">
      silverwind
    </div>
      <div class="item" data-value="16251" title="silverwind-org" tabindex="-1">
        <img class="ui mini image" src="/user/avatar/silverwind-org/-1">
        silverwind-org
      </div>
      <div class="item" data-value="1069" title="my-cool-organization" tabindex="-1">
        <img class="ui mini image" src="/user/avatar/my-cool-organization/-1">
        my-cool-organization
      </div>
  </div>
</div>

@silverwind commented on GitHub (Nov 18, 2019): @Jookia is there some way to verify whether the customization from https://github.com/go-gitea/gitea/pull/8638 works? For example on https://try.gitea.io/repo/create, I don't see any `aria-*` attributes on the dropdown HTML. Is it already broken? ````html <div class="ui selection owner dropdown" tabindex="0"> <input type="hidden" id="uid" name="uid" value="476" required=""> <span class="text" title="silverwind"><img class="ui mini image" src="/user/avatar/silverwind/-1"> silverwind</span> <i class="dropdown icon" tabindex="0"><div class="menu" tabindex="-1"></div></i> <div class="menu" tabindex="-1"> <div class="item active selected" data-value="476" title="silverwind" tabindex="-1"> <img class="ui mini image" src="/user/avatar/silverwind/-1"> silverwind </div> <div class="item" data-value="16251" title="silverwind-org" tabindex="-1"> <img class="ui mini image" src="/user/avatar/silverwind-org/-1"> silverwind-org </div> <div class="item" data-value="1069" title="my-cool-organization" tabindex="-1"> <img class="ui mini image" src="/user/avatar/my-cool-organization/-1"> my-cool-organization </div> </div> </div>

GiteaMirror commented

2025-11-02 05:45:25 -06:00

@Jookia commented on GitHub (Nov 18, 2019):

That's not a dropdown menu, it's a dropdown selection. The language selection at the bottom of the page has aria-* attributes

@Jookia commented on GitHub (Nov 18, 2019): That's not a dropdown menu, it's a dropdown selection. The language selection at the bottom of the page has aria-* attributes

GiteaMirror commented

2025-11-02 05:45:25 -06:00

@silverwind commented on GitHub (Nov 18, 2019):

Thanks, I see the attributes there.

@silverwind commented on GitHub (Nov 18, 2019): Thanks, I see the attributes there.

GiteaMirror referenced this issue

2025-11-02 12:32:39 -06:00

[PR #4306] [MERGED] Create api-usage doc page #17326

Sign in to join this conversation.