Row alignment issue in git-blame view #4272

New Issue

GiteaMirror · 2025-11-02T05:44:27-06:00

GiteaMirror commented

2025-11-02 05:44:27 -06:00

Originally created by @hapasa on GitHub (Nov 8, 2019).

Gitea version (or commit ref): 1.10.0+rc2-9-g68b7f9f3f
Git version: 1.8.3
Operating system: Red Hat Enterprise Linux Server release 7.6 (Maipo)
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Description

the rows in two columns in git-blame view do not match.
Tried with Chrome, IE, Firefox. Upgrade from Gitea 1.7.3, no custom CSS in use.
...

Screenshots

Originally created by @hapasa on GitHub (Nov 8, 2019). - Gitea version (or commit ref): 1.10.0+rc2-9-g68b7f9f3f - Git version: 1.8.3 - Operating system: Red Hat Enterprise Linux Server release 7.6 (Maipo) - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description the rows in two columns in git-blame view do not match. Tried with Chrome, IE, Firefox. Upgrade from Gitea 1.7.3, no custom CSS in use. ... ## Screenshots ![image](https://user-images.githubusercontent.com/8208561/68476554-486a5980-022b-11ea-9972-56639bc0afaa.png)

GiteaMirror added the issue/confirmed type/enhancement labels 2025-11-02 05:44:27 -06:00

GiteaMirror closed this issue

2025-11-02 05:44:27 -06:00

GiteaMirror commented

2025-11-02 05:44:27 -06:00

@mrsdizzie commented on GitHub (Nov 8, 2019):

(I think) This is general problem of how blame was designed where the entire contents are inside a single table row and can't possible ever work right all the time:

d9be82bd00/templates/repo/blame.tmpl (L39)

and

d9be82bd00/routers/repo/blame.go (L223)

The view part would probably need to be redesigned at least to have each commit/blame be its own table row similar to diff view

@mrsdizzie commented on GitHub (Nov 8, 2019): (I think) This is general problem of how blame was designed where the entire contents are inside a single table row and can't possible ever work right all the time: https://github.com/go-gitea/gitea/blob/d9be82bd003d2dfd1c2bd31bf871d49c898b5c6b/templates/repo/blame.tmpl#L39 and https://github.com/go-gitea/gitea/blob/d9be82bd003d2dfd1c2bd31bf871d49c898b5c6b/routers/repo/blame.go#L223 The view part would probably need to be redesigned at least to have each commit/blame be its own table row similar to diff view

GiteaMirror commented

2025-11-02 05:44:28 -06:00

@stale[bot] commented on GitHub (Jan 8, 2020):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 8, 2020): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:44:28 -06:00

@septatrix commented on GitHub (Apr 5, 2020):

This can also be easily observed at this official repo: (gitea.com - gitea/tea)

@septatrix commented on GitHub (Apr 5, 2020): This can also be easily observed at this official repo: ([gitea.com - gitea/tea](https://gitea.com/gitea/tea/blame/branch/master/modules/git/url.go))

GiteaMirror commented

2025-11-02 05:44:28 -06:00

@camlafit commented on GitHub (Aug 12, 2021):

Hello

We confirm this behavior for example on https://git.spip.net/spip-contrib-extensions/formidable/blame/branch/v4/formidable_fonctions.php or https://try.gitea.io/asahiocean/AsahiOcean/blame/branch/main/README.md

Mac / Firefox / 90.0.2 :

Mac / Safari :

Could be partially solve with theses changes

.blame-info {  
    line-height: 20px;  
‎}  

 .lines-commit .ui.avatar.image {  
‎height: 16px;  
‎width: 16px;  
}

But I presume this patch will broke with other use case as size are in pixel.

@camlafit commented on GitHub (Aug 12, 2021): Hello We confirm this behavior for example on https://git.spip.net/spip-contrib-extensions/formidable/blame/branch/v4/formidable_fonctions.php or https://try.gitea.io/asahiocean/AsahiOcean/blame/branch/main/README.md Mac / Firefox / 90.0.2 : ![Capture d'ecran 2021-08-12 a 12 22 00](https://user-images.githubusercontent.com/209915/129183358-c77b3c83-5ab3-4cc1-85a3-842813e3a80f.png) Mac / Safari : ![Capture d'ecran 2021-08-12 a 12 27 41](https://user-images.githubusercontent.com/209915/129183624-26226f35-d974-4efc-8406-631fe22880fa.png) Could be partially solve with theses changes ``` .blame-info { line-height: 20px; ‎} .lines-commit .ui.avatar.image { ‎height: 16px; ‎width: 16px; } ``` But I presume this patch will broke with other use case as size are in pixel.

GiteaMirror commented

2025-11-02 05:44:28 -06:00

@wxiaoguang commented on GitHub (Apr 13, 2022):

It should have been fixed in latest version.

@wxiaoguang commented on GitHub (Apr 13, 2022): It should have been fixed in latest version.

GiteaMirror referenced this issue

2025-11-02 12:32:18 -06:00

[PR #4272] [CLOSED] Add support for different journal modes #17311

Sign in to join this conversation.