github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Commits avatar when email set to private, and misc. #422

New Issue
Closed
opened 2025-11-02 03:22:52 -06:00 by GiteaMirror · 8 comments
GiteaMirror commented 2025-11-02 03:22:52 -06:00
Owner
Copy Link

Originally created by @Fastidious on GitHub (Mar 4, 2017).

  • Gitea version (or commit ref): 1.0.0+373-gd76d67d
  • Git version: 2.7.4
  • Operating system: Ubuntu 16.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

If I commit, while having the email setting to keep it private, avatar will not show on commits (see https://gits.quark.business/David/collantes.us/commits/master). The one showing avatar is last commit, after unticking Keep email address private.

Also note the tick box on search, near All, it seems to be needing some padding.

Screenshots

screen shot 2017-03-04 at 18 11 57

Originally created by @Fastidious on GitHub (Mar 4, 2017). - Gitea version (or commit ref): `1.0.0+373-gd76d67d` - Git version: `2.7.4` - Operating system: `Ubuntu 16.04` - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No - [ ] Not relevant - Log gist: ## Description If I commit, while having the email setting to keep it private, avatar will not show on commits (see https://gits.quark.business/David/collantes.us/commits/master). The one showing avatar is last commit, after unticking `Keep email address private.` Also note the tick box on search, near `All`, it seems to be needing some padding. ## Screenshots ![screen shot 2017-03-04 at 18 11 57](https://cloud.githubusercontent.com/assets/8352292/23583019/199845be-0106-11e7-88f5-998b5ab77dca.png)
GiteaMirror added the type/questionissue/stale labels 2025-11-02 03:22:52 -06:00
GiteaMirror commented 2025-11-02 03:22:53 -06:00
Author
Owner
Copy Link

@Fastidious commented on GitHub (Mar 4, 2017):

I think I figured out the avatar problem.

On app.ini, under [service] there is the NO_REPLY_ADDRESS setting. It is not an address what should be entered, but a not reply domain. I had not-a-valid-address@quark.business and that was causing my address to become david@not-a-valid-address@quark.business (saw this on the logs) which is terribly wrong. Changing NO_REPLY_ADDRESS to not-a-valid-email.quark.business fixed the problem. See screenshot:

Shows the invalid email address

The little UI glitch (tick box and All too close) remains.

@Fastidious commented on GitHub (Mar 4, 2017): I think I figured out the avatar problem. On `app.ini`, under `[service]` there is the `NO_REPLY_ADDRESS` setting. It is not an address what should be entered, but a not reply `domain`. I had `not-a-valid-address@quark.business` and that was causing my address to become `david@not-a-valid-address@quark.business` (saw this on the logs) which is terribly wrong. Changing `NO_REPLY_ADDRESS` to `not-a-valid-email.quark.business` fixed the problem. See screenshot: ![Shows the invalid email address](https://cloud.githubusercontent.com/assets/8352292/23583157/307d4654-010a-11e7-85ff-5ecba8a86b94.png) The little UI glitch (tick box and `All` too close) remains.
GiteaMirror commented 2025-11-02 03:22:53 -06:00
Author
Owner
Copy Link

@Fastidious commented on GitHub (Mar 5, 2017):

@lunny bottom line, the setting NO_REPLY_ADDRESS has a misleading name. It is used to create the private address, but it isn't an email address what the value should be, but an invented TLD.

@Fastidious commented on GitHub (Mar 5, 2017): @lunny bottom line, the setting `NO_REPLY_ADDRESS` has a misleading name. It is used to create the `private` address, but it isn't an email address what the value should be, but an invented `TLD`.
GiteaMirror commented 2025-11-02 03:22:53 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 5, 2017):

Yes. I see. It's a misleading name.

@lunny commented on GitHub (Mar 5, 2017): Yes. I see. It's a misleading name.
GiteaMirror commented 2025-11-02 03:22:53 -06:00
Author
Owner
Copy Link

@Fastidious commented on GitHub (Mar 13, 2017):

@lunny should I split this issue? The second part did not relate to the first, I should not have piggy bagged two completely different things into one. Let me know.

@Fastidious commented on GitHub (Mar 13, 2017): @lunny should I split this issue? The second part did not relate to the first, I should not have piggy bagged two completely different things into one. Let me know.
GiteaMirror commented 2025-11-02 03:22:53 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 13, 2017):

OK. Feel free to do that.

@lunny commented on GitHub (Mar 13, 2017): OK. Feel free to do that.
GiteaMirror commented 2025-11-02 03:22:54 -06:00
Author
Owner
Copy Link

@mohammed90 commented on GitHub (Jun 13, 2018):

Isn't this a bug? When Keep email address private is checked, commits done via UI (file edits directly on Gitea and merging pull-requests) do not link to the user's profile. Doesn't Gitea know who the user is who committed or pushed the commit? It properly links to the user profile when the commits are directly pushed from local to Gitea.

@mohammed90 commented on GitHub (Jun 13, 2018): Isn't this a bug? When `Keep email address private` is checked, commits done via UI (file edits directly on Gitea and merging pull-requests) do not link to the user's profile. Doesn't Gitea know who the user is who committed or pushed the commit? It properly links to the user profile when the commits are directly pushed from local to Gitea.
GiteaMirror commented 2025-11-02 03:22:54 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Jun 19, 2018):

@Mohammed90 users are linked only through e-mail addresses.

@lafriks commented on GitHub (Jun 19, 2018): @Mohammed90 users are linked only through e-mail addresses.
GiteaMirror commented 2025-11-02 03:22:54 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Jan 23, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 23, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/stale type/question
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?