rewrite docker stuff #42

Closed
opened 2025-11-02 03:05:29 -06:00 by GiteaMirror · 16 comments
Owner

Originally created by @xinity on GitHub (Nov 7, 2016).

Originally assigned to: @xinity on GitHub.

as gitea grows, we have to rewrite docker stuff in the docker dir.

this issue will stays open until PR is merged and will serve a repo for comments.

feel free to add what you think should be done regarding docker build

Originally created by @xinity on GitHub (Nov 7, 2016). Originally assigned to: @xinity on GitHub. as gitea grows, we have to rewrite docker stuff in the docker dir. this issue will stays open until PR is merged and will serve a repo for comments. feel free to add what you think should be done regarding docker build
GiteaMirror added the type/enhancementpr/wip labels 2025-11-02 03:05:29 -06:00
Author
Owner

@xinity commented on GitHub (Nov 7, 2016):

keep s6 as an init replacement.

@xinity commented on GitHub (Nov 7, 2016): keep s6 as an init replacement.
Author
Owner

@xinity commented on GitHub (Nov 7, 2016):

rewrite env variables

@xinity commented on GitHub (Nov 7, 2016): rewrite env variables
Author
Owner

@xinity commented on GitHub (Nov 7, 2016):

dockerfile cleanup

@xinity commented on GitHub (Nov 7, 2016): dockerfile cleanup
Author
Owner

@DblK commented on GitHub (Nov 7, 2016):

I would suggest to have the smaller image as possible and by doing so, the compilation should be done outside and the binary pushed to the docker (maybe from scratch instead alpine).

I could provide later a link to a docker images that can be used to build Go program and make docker images without compiler program.

Edit 11/10/16:
Here is the link to build dockerfile for Go program with image "SCRATCH"

@DblK commented on GitHub (Nov 7, 2016): I would suggest to have the smaller image as possible and by doing so, the compilation should be done outside and the binary pushed to the docker (maybe from scratch instead alpine). I could provide later a link to a docker images that can be used to build Go program and make docker images without compiler program. Edit 11/10/16: Here is the [link](https://github.com/CenturyLinkLabs/golang-builder) to build dockerfile for Go program with image "SCRATCH"
Author
Owner

@xinity commented on GitHub (Nov 7, 2016):

@DblK feel free to update your comment with the appropriate link :)

@xinity commented on GitHub (Nov 7, 2016): @DblK feel free to update your comment with the appropriate link :)
Author
Owner

@tboerger commented on GitHub (Nov 7, 2016):

We will use drone to build the binary outside of the docker image, the drone pipeline is in preparation ;)

@tboerger commented on GitHub (Nov 7, 2016): We will use drone to build the binary outside of the docker image, the drone pipeline is in preparation ;)
Author
Owner

@xinity commented on GitHub (Nov 7, 2016):

@tboerger nice !

then @DblK send the link to me :) i'd be happy to learn moaaarrrr go :)

@xinity commented on GitHub (Nov 7, 2016): @tboerger nice ! then @DblK send the link to me :) i'd be happy to learn moaaarrrr go :)
Author
Owner

@willemvd commented on GitHub (Nov 8, 2016):

why do we need that s6 stuff instead of setting things up in the dockerfile?

@willemvd commented on GitHub (Nov 8, 2016): why do we need that s6 stuff instead of setting things up in the dockerfile?
Author
Owner

@tboerger commented on GitHub (Nov 9, 2016):

@willemvd we need s6 as process manager because we will run more than a single service within the container, at least we need Gitea and openSSH.

@tboerger commented on GitHub (Nov 9, 2016): @willemvd we need s6 as process manager because we will run more than a single service within the container, at least we need Gitea and openSSH.
Author
Owner

@ghost commented on GitHub (Nov 11, 2016):

I would strongly recommend against using scratch as that renders any form of shell scripting invalid.

@ghost commented on GitHub (Nov 11, 2016): I would strongly recommend against using `scratch` as that renders any form of shell scripting invalid.
Author
Owner

@ptman commented on GitHub (Nov 11, 2016):

The way you say it makes it sound like avoiding shell scripts is a bad thing

@ptman commented on GitHub (Nov 11, 2016): The way you say it makes it sound like avoiding shell scripts is a bad thing
Author
Owner

@ghost commented on GitHub (Nov 11, 2016):

Yes, it breaks many things. Including git-hooks and https://github.com/go-gitea/git.

@ghost commented on GitHub (Nov 11, 2016): Yes, it breaks many things. Including git-hooks and https://github.com/go-gitea/git.
Author
Owner

@tboerger commented on GitHub (Nov 11, 2016):

Nobody wants to use scratch, alpine is a perfect base

@tboerger commented on GitHub (Nov 11, 2016): Nobody wants to use scratch, alpine is a perfect base
Author
Owner

@ghost commented on GitHub (Nov 11, 2016):

@tboerger, I just wanted to let anyone that likes @DblK's idea know that it's not going to be good if we use scratch as base.

@ghost commented on GitHub (Nov 11, 2016): @tboerger, I just wanted to let anyone that likes @DblK's idea know that it's not going to be good if we use scratch as base.
Author
Owner

@ogarcia commented on GitHub (Nov 14, 2016):

Using scratch as base not is (in this case) a good idea cause you need OpenSSH and shell scripts.

@ogarcia commented on GitHub (Nov 14, 2016): Using scratch as base not is (in this case) a good idea cause you need OpenSSH and shell scripts.
Author
Owner

@tboerger commented on GitHub (Dec 3, 2016):

We already refactored docker

@tboerger commented on GitHub (Dec 3, 2016): We already refactored docker
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#42