github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-10 16:44:50 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Most attachments deleted from server when upgrading to 1.10.0-dev from 1.9.3 #4082

New Issue
Closed
opened 2025-11-02 05:36:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 05:36:56 -06:00
Owner
Copy Link

Originally created by @guillep2k on GitHub (Oct 9, 2019).

I've just upgraded my company server to 1.10.0-dev from 1.9.3 and most attachments from issues were gone from the file-system (they were still there in the attachment table). Lucky me I had a good backup at hand and recovered them all, so no worries there. However, this is something we should definite look into.

I've checked what migration steps new to 1.10 are related to attachments and I've found this step from #6068:

3810fa48ac/models/migrations/v96.go (L16)

I'm not sure about the reasoning of the function, but it seems to me that it deletes all but those related to releases (EDIT: or comments; those deleted were from issues or PR).

Originally created by @guillep2k on GitHub (Oct 9, 2019). I've just upgraded my company server to 1.10.0-dev from 1.9.3 and most attachments from issues were gone from the file-system (they were still there in the `attachment` table). Lucky me I had a good backup at hand and recovered them all, so no worries there. However, this is something we should definite look into. I've checked what migration steps new to 1.10 are related to attachments and I've found this step from #6068: https://github.com/go-gitea/gitea/blob/3810fa48ac46620432fbf91571a01eeea0b460b3/models/migrations/v96.go#L16 I'm not sure about the reasoning of the function, but it seems to me that it deletes all but those related to releases (EDIT: or comments; those deleted were from issues or PR).
GiteaMirror added the type/bug label 2025-11-02 05:36:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4082
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?