Make Protected Branches -> Approvals section easier to understand #4071

New Issue

GiteaMirror · 2025-11-02T05:36:34-06:00

GiteaMirror commented

2025-11-02 05:36:34 -06:00

Originally created by @worthy7 on GitHub (Oct 7, 2019).

Small issue concerning UX design which at least caused me a little bit of confusion.

Allow only to merge pull request with enough positive reviews of whitelisted users or teams.
-> Allow merging of pull requests only with enough positive reviews from approvers.
Whitelisted reviewers: -> Reviewers:
default text set to Search contributing teams or users...
Add a checkbox first saying "Require approvals", when unchecked the two options are disabled, when checked, the "number of approvals" is minimum 1 and the input for Approvers should be "required" (input required). Doing a dynamic calculation to see if they match is not worth it since team sizes can change in the future

For reference here is how GitHub looks

I made a mock-up design for someone to follow:

Open for discussion!

Originally created by @worthy7 on GitHub (Oct 7, 2019). Small issue concerning UX design which at least caused me a little bit of confusion. 1. `Allow only to merge pull request with enough positive reviews of whitelisted users or teams.` -> `Allow merging of pull requests only with enough positive reviews from approvers.` 2. `Whitelisted reviewers:` -> `Reviewers:` 3. default text set to `Search contributing teams or users...` 4. Add a checkbox first saying "Require approvals", when unchecked the two options are disabled, when checked, the "number of approvals" is minimum 1 and the input for Approvers should be "required" (input required). Doing a dynamic calculation to see if they match is not worth it since team sizes can change in the future For reference here is how GitHub looks ![image](https://user-images.githubusercontent.com/4762399/66278857-f52d8000-e8e7-11e9-8f1b-51d1f4c1fcb9.png) I made a mock-up design for someone to follow: ![image](https://user-images.githubusercontent.com/4762399/66278961-ee533d00-e8e8-11e9-98b3-dbd947c57e7f.png) Open for discussion!

GiteaMirror added the issue/confirmed type/proposal labels 2025-11-02 05:36:34 -06:00

GiteaMirror closed this issue

2025-11-02 05:36:35 -06:00

GiteaMirror commented

2025-11-02 05:36:35 -06:00

@bagasme commented on GitHub (Oct 7, 2019):

Please consider also the case when the approvers are writers, as per #8288 (which I open the issue).

@bagasme commented on GitHub (Oct 7, 2019): Please consider also the case when the approvers are *writers*, as per #8288 (which I open the issue).

GiteaMirror commented

2025-11-02 05:36:35 -06:00

@stale[bot] commented on GitHub (Dec 6, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Dec 6, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:36:36 -06:00

@kdumontnu commented on GitHub (Aug 22, 2024):

I think this issue is pretty out of date and should be closed.

There are still some things that need to be explained better in the UI (see discussion here). Specifically:

"reviews from anyone with write access" -> "reviews from anyone with code write access" (unless that logic is changed in #31886)
"Allow only to merge pull request with enough positive reviews from reviewers with code write access."

Here is what the page currently looks like:

@kdumontnu commented on GitHub (Aug 22, 2024): I think this issue is pretty out of date and should be closed. There are still some things that need to be explained better in the UI ([see discussion here](https://github.com/go-gitea/gitea/pull/31886#issuecomment-2304825715)). Specifically: - "reviews from anyone with write access" -> "reviews from anyone with code write access" (unless that logic is changed in #31886) - "Allow only to merge pull request with enough positive reviews from reviewers with code write access." Here is what the page currently looks like: <img width="1030" alt="image" src="https://github.com/user-attachments/assets/a81a5904-90b7-4d91-af65-f7397f34fa82">

GiteaMirror referenced this issue

2025-11-02 12:30:12 -06:00

[PR #4071] [MERGED] Fix drone CLI install link #17225

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#4071