github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-08-01 07:03:57 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Allow Repo Administrators to (Force) Merge "Review Required" PRs #4007

New Issue
Closed
opened 2025-11-02 05:33:52 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 05:33:52 -06:00
Owner
Copy Link
Copy Source

Originally created by @bagasme on GitHub (Sep 24, 2019).

  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.17.1
  • Operating system: Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
    (not relevant)

Description

In cases whether there is an open PR against protected branch that requires approved reviews from whitelisted reviewers, and all reviewers aren't available in time, repo administrators can still merge that PR. An example when this feature is useful is when a PR contains important security fixes.

Screenshots

This screenshot is from my localhost Gitea instance on a computer. A user (which is repo administrator) open a PR against protected branch (master). Required approvals are 1. However, despite that he is an admin, he can't (force) merge his PR without approvals. That is, there isn't Merge Pull Request button.
image
On the other hand, on GitHub, there is Merge Pull Request button which allows admins to merge
PR without review approvals (that is, force merging).
image

Originally created by @bagasme on GitHub (Sep 24, 2019). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 1.9.0 - Git version: 2.17.1 - Operating system: Ubuntu 18.04 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: (not relevant) ## Description In cases whether there is an open PR against protected branch that requires approved reviews from whitelisted reviewers, and all reviewers aren't available in time, repo administrators can still merge that PR. An example when this feature is useful is when a PR contains important security fixes. ## Screenshots <!-- **If this issue involves the Web Interface, please include a screenshot** --> This screenshot is from my `localhost` Gitea instance on a computer. A user (which is repo administrator) open a PR against protected branch (`master`). Required approvals are 1. However, despite that he is an admin, he can't (force) merge his PR without approvals. That is, there isn't `Merge Pull Request` button. ![image](https://user-images.githubusercontent.com/40219486/65496477-bf010100-dee2-11e9-8a40-6de883301b2c.png) On the other hand, on GitHub, there is `Merge Pull Request` button which allows admins to merge PR without review approvals (that is, force merging). ![image](https://user-images.githubusercontent.com/40219486/65496762-42225700-dee3-11e9-909a-2c640bf3923c.png)
GiteaMirror commented 2025-11-02 05:33:53 -06:00
Author
Owner
Copy Link
Copy Source

@lunny commented on GitHub (Sep 24, 2019):

I think maybe I have resolved this on #7481 ?

@lunny commented on GitHub (Sep 24, 2019): I think maybe I have resolved this on #7481 ?
GiteaMirror commented 2025-11-02 05:33:53 -06:00
Author
Owner
Copy Link
Copy Source

@bagasme commented on GitHub (Sep 24, 2019):

I think maybe I have resolved this on #7481 ?

@lunny Yes this issue is duplicate. Please close.

@bagasme commented on GitHub (Sep 24, 2019): > I think maybe I have resolved this on #7481 ? @lunny Yes this issue is duplicate. Please close.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4007