github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-11 17:46:29 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Commits should only close/reopen issues if the issue has the correct branch #4000

New Issue
Closed
opened 2025-11-02 05:33:36 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 05:33:36 -06:00
Owner
Copy Link

Originally created by @guillep2k on GitHub (Sep 22, 2019).

  • Gitea version (or commit ref): 1.9.3

Description

Currently a commit can close or reopen an issue it is referencing, either if repo.CloseIssuesViaCommitInAnyBranch is set or when the commit is being pushed to the default branch. However, if Issue.Ref is set, it should be used instead of the default branch.

63ff61615e/models/action.go (L603-L607)

Originally created by @guillep2k on GitHub (Sep 22, 2019). - Gitea version (or commit ref): 1.9.3 ## Description Currently a commit can close or reopen an issue it is referencing, either if `repo.CloseIssuesViaCommitInAnyBranch` is set or when the commit is being pushed to the default branch. However, if `Issue.Ref` is set, it should be used instead of the default branch. https://github.com/go-gitea/gitea/blob/63ff61615ec6aaa25887f8ce605c9082c106a34b/models/action.go#L603-L607
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 05:33:36 -06:00
GiteaMirror commented 2025-11-02 05:33:38 -06:00
Author
Owner
Copy Link

@adelowo commented on GitHub (Sep 23, 2019):

It is there for backward compatibility

See https://github.com/go-gitea/gitea/pull/5992 and https://github.com/go-gitea/gitea/issues/5957

@adelowo commented on GitHub (Sep 23, 2019): It is there for backward compatibility See https://github.com/go-gitea/gitea/pull/5992 and https://github.com/go-gitea/gitea/issues/5957
GiteaMirror commented 2025-11-02 05:33:38 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Sep 23, 2019):

It is there for backward compatibility

See #5992 and #5957

@adelowo Using CloseIssuesViaCommitInAnyBranch is alright, but if it's not set, an the issue is marked on branch release (Issue.Ref == release), a commit on dev should not close the issue.

@guillep2k commented on GitHub (Sep 23, 2019): > > > It is there for backward compatibility > > See #5992 and #5957 @adelowo Using `CloseIssuesViaCommitInAnyBranch` is alright, but if it's _not set_, an the issue is marked on branch `release` (`Issue.Ref` == `release`), a commit on `dev` should not close the issue.
GiteaMirror commented 2025-11-02 05:33:38 -06:00
Author
Owner
Copy Link

@adelowo commented on GitHub (Sep 23, 2019):

Ha true

@adelowo commented on GitHub (Sep 23, 2019): Ha true
GiteaMirror commented 2025-11-02 05:33:38 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Nov 22, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Nov 22, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 05:33:38 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Nov 22, 2019):

This was fixed in #8875

@guillep2k commented on GitHub (Nov 22, 2019): This was fixed in #8875
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4000
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?