(Enhancement) Add "Review Required" Identifier on Pull Requests Targeting Protected Branches with Required Approvals #3997

New Issue

GiteaMirror · 2025-11-02T05:33:31-06:00

GiteaMirror commented

2025-11-02 05:33:31 -06:00

Originally created by @bagasme on GitHub (Sep 22, 2019).

Gitea version (or commit ref): 1.9.0
Git version: 2.17.1
Operating system: Ubuntu 18.04
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant (I couldn't access because of slow internet connection)
Log gist:
(not relevant)

Description

In Pull Requests tab of Gitea repository, there isn't Review Required text next to who and when the pull request that merge into protected branch with required approvals setting was made. Thus, users don't know whether a PR requires reviews/approvals without having to click into individual PR link.

Screenshots

This screenshot below is from my localhost Gitea instance on my computer. I created learnPRHomework repository and set master branch protected with 1 required approval. Other user (bagas) open a pull request to this protected branch. Note that there isn't Review Required text as described in the description above:

On the other hand, PR on GitHub with similar condition have Review Required text (the screenshot is from linode-docs PRs:

Originally created by @bagasme on GitHub (Sep 22, 2019).   - Gitea version (or commit ref): 1.9.0 - Git version: 2.17.1 - Operating system: Ubuntu 18.04 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant (I couldn't access because of slow internet connection) - Log gist: (not relevant) ## Description In `Pull Requests` tab of Gitea repository, there isn't `Review Required` text next to who and when the pull request that merge into protected branch with required approvals setting was made. Thus, users don't know whether a PR requires reviews/approvals without having to click into individual PR link. ## Screenshots  This screenshot below is from my `localhost` Gitea instance on my computer. I created `learnPRHomework` repository and set `master` branch protected with 1 required approval. Other user (`bagas`) open a pull request to this protected branch. Note that there isn't `Review Required` text as described in the description above: ![Screenshot_2019-09-22 learnPRHomework](https://user-images.githubusercontent.com/40219486/65384549-d8bd0f80-dd4d-11e9-87e5-429fb8d4caf9.png) On the other hand, PR on GitHub with similar condition have `Review Required` text (the screenshot is from [linode-docs PRs](https://github.com/linode/docs/pulls): ![Screenshot_2019-09-22 linode docs](https://user-images.githubusercontent.com/40219486/65384577-1326ac80-dd4e-11e9-909d-acc5ccdb8c83.png)

GiteaMirror added the issue/confirmed type/enhancement labels 2025-11-02 05:33:31 -06:00

GiteaMirror closed this issue

2025-11-02 05:33:32 -06:00

GiteaMirror commented

2025-11-02 05:33:32 -06:00

@stale[bot] commented on GitHub (Nov 21, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Nov 21, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:33:32 -06:00

@6543 commented on GitHub (Apr 26, 2020):

I couldn't find the specific pull but its arlready implemented:

@6543 commented on GitHub (Apr 26, 2020): I couldn't find the specific pull but its arlready implemented: ![Bildschirmfoto zu 2020-04-26 15-59-36](https://user-images.githubusercontent.com/24977596/80309731-151a8780-87d7-11ea-9cb9-e9165bed38c5.png)

GiteaMirror referenced this issue

2025-11-02 12:28:57 -06:00

[PR #3997] [MERGED] Added doc for 'IMPORT_LOCAL_PATHS' #17189

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#3997