UX: When saving a comment edit, there is no indication of progress or error #3969

New Issue

GiteaMirror · 2025-11-02T05:32:11-06:00

GiteaMirror commented

2025-11-02 05:32:11 -06:00

Originally created by @abread on GitHub (Sep 17, 2019).

Gitea version (or commit ref): 1.9.2, 1.9.3
Git version: any
Operating system: any
Database (use [x]): any
Can you reproduce the bug at https://try.gitea.io:
- Yes https://try.gitea.io/testASDL/asdfsadkfkjs/issues/1#issuecomment-23230
- No
- Not relevant

Description

Start editing an issue comment.
When you hit save, the edit interface is closed and the only feedback you have of your edit being saved is the comment text changing (when the fetch that sends the edit succeeds).

This is usually fine, but when the network conditions are a bit slower, one gets frustrated not seeing their edit on the screen, and not seeing any sign of progress. It's easier to see when the edit is big or by manipulating the network latency in Chrome/Chromium's DevTools.

When I noticed this I also checked what happens when the request fails by enabling "Offline mode" in Chrome/Chromium's DevTools before clicking save. It just fails silently.

Fix suggestion: It should show an overlay on top of the editing interface to indicate that it is being saved and the user should wait, and only close the interface after it's finished saving. If an error occurs, don't close the edit interface and tell the user it failed.

Originally created by @abread on GitHub (Sep 17, 2019). - Gitea version (or commit ref): 1.9.2, 1.9.3 - Git version: any - Operating system: any - Database (use `[x]`): any - Can you reproduce the bug at https://try.gitea.io: - [x] Yes https://try.gitea.io/testASDL/asdfsadkfkjs/issues/1#issuecomment-23230 - [ ] No - [ ] Not relevant ## Description Start editing an issue comment. When you hit save, the edit interface is closed and the only feedback you have of your edit being saved is the comment text changing (when the fetch that sends the edit succeeds). This is usually fine, but when the network conditions are a bit slower, one gets frustrated not seeing their edit on the screen, and not seeing any sign of progress. It's easier to see when the edit is big or by manipulating the network latency in Chrome/Chromium's DevTools. When I noticed this I also checked what happens when the request fails by enabling "Offline mode" in Chrome/Chromium's DevTools before clicking save. It just fails silently. Fix suggestion: It should show an overlay on top of the editing interface to indicate that it is being saved and the user should wait, and only close the interface after it's finished saving. If an error occurs, don't close the edit interface and tell the user it failed.

GiteaMirror added the issue/confirmed topic/ui-interaction type/enhancement labels 2025-11-02 05:32:11 -06:00

GiteaMirror closed this issue

2025-11-02 05:32:11 -06:00

GiteaMirror commented

2025-11-02 05:32:11 -06:00

@stale[bot] commented on GitHub (Nov 16, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Nov 16, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:32:12 -06:00

@abread commented on GitHub (Nov 16, 2019):

It's still an issue, stale bot, just not a very important one

@abread commented on GitHub (Nov 16, 2019): It's still an issue, stale bot, just not a very important one

GiteaMirror commented

2025-11-02 05:32:12 -06:00

@wxiaoguang commented on GitHub (Apr 13, 2022):

Dup of