github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 02:57:44 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Mail - closing pull request generates same message as new pull request #3903

New Issue
Closed
opened 2025-11-02 05:30:09 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 05:30:09 -06:00
Owner
Copy Link

Originally created by @vakabus on GitHub (Sep 5, 2019).

  • Gitea version (or commit ref): c5ec66a
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No - I haven't received any emails from there
    • Not relevant

Description

When closing a pull request without a merge, an email notification is sent out with the same content as the message about new pull request. Nothing indicates, that the pull request has been closed. Expected behaviour would be, that the email would at least contain "pull request closed".

Originally created by @vakabus on GitHub (Sep 5, 2019). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): c5ec66a - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No - I haven't received any emails from there - [ ] Not relevant --- ## Description When closing a pull request without a merge, an email notification is sent out with the same content as the message about new pull request. Nothing indicates, that the pull request has been closed. Expected behaviour would be, that the email would at least contain "pull request closed".
GiteaMirror added the type/enhancement label 2025-11-02 05:30:09 -06:00
GiteaMirror commented 2025-11-02 05:30:10 -06:00
Author
Owner
Copy Link

@vakabus commented on GitHub (Oct 5, 2019):

Pretty much same issue with different action - when reopening PR, the first comment is sent out again. Expected would be a simple message just about reopening it.

@vakabus commented on GitHub (Oct 5, 2019): Pretty much same issue with different action - when reopening PR, the first comment is sent out again. Expected would be a simple message just about reopening it.
GiteaMirror commented 2025-11-02 05:30:10 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Oct 5, 2019):

Should be fixed by #8329 by improving the subject line. I think it's good to maintain the original issue content as the body of the mail if the subject is clear about what has been done.

@guillep2k commented on GitHub (Oct 5, 2019): Should be fixed by #8329 by improving the subject line. I think it's good to maintain the original issue content as the body of the mail if the subject is clear about what has been done.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3903
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?