Team Names too stingy #3890

New Issue

GiteaMirror · 2025-11-02T05:29:44-06:00

GiteaMirror commented

2025-11-02 05:29:44 -06:00

Originally created by @worthy7 on GitHub (Sep 4, 2019).

Support in Japanese is サポート, this character isn't actually the regular - but it still gets blocked.
Gitea Version: 1.8.2

Originally created by @worthy7 on GitHub (Sep 4, 2019). ![image](https://user-images.githubusercontent.com/4762399/64226929-54305b80-cf1c-11e9-8ac2-5cc9c563fd21.png) Support in Japanese is サポート, this character isn't actually the regular - but it still gets blocked. Gitea Version: 1.8.2

GiteaMirror added the type/proposal label 2025-11-02 05:29:44 -06:00

GiteaMirror closed this issue

2025-11-02 05:29:44 -06:00

GiteaMirror commented

2025-11-02 05:29:45 -06:00

@guillep2k commented on GitHub (Sep 4, 2019):

Here the problem is not the chōonpu character (ー), but the fact that you're trying to use katakana.

This is more difficult a problem than it may seem.

Currently, team names follow the same or similar rules as for organizations or repositories, which restricts to use only ASCII characters: letters, numbers, _, - and in some cases, . too. However, teams are not bound to file-system resources, so accepting other scripts (like katakana or hiragana) should be safe in some cases as long that those scripts don't include symbols that can cause confusion for being too similar. I know a few scripts that should be safe to support:

Katakana (Japanese)
Hiragana (Japanese)
Hangul (Korean - U+115F and U+1160 might cause problems, though)
Cyrilic (Russian, etc.)
Greek

But not all scripts are safe or should be supported. For instance, the unicode CJK (unified Chinese, Japanese, Korean) contains lots of characters that can easily be confused with others, like full and half-width versions, different types of dot (e.g. º), different letter-like symbols, etc. The same goes with the Latin scripts variants like "áàäâã", etc.

These validations are currently taken from Macaron:
4cb1bdddc8/vendor/gitea.com/macaron/binding/binding.go (L268-L272)

And used here:
4cb1bdddc8/modules/structs/org_team.go (L20-L40)

However, if we decide to support any of this, either we restrict the extended support to a reduced set of "easy" scripts, or we need a profound analysis of the impact of such modification.

@guillep2k commented on GitHub (Sep 4, 2019): Here the problem is not the chōonpu character (ー), but the fact that you're trying to use katakana. This is more difficult a problem than it may seem. Currently, team names follow the same or similar rules as for organizations or repositories, which restricts to use only ASCII characters: letters, numbers, `_`, `-` and in some cases, `.` too. However, teams are not bound to file-system resources, so accepting other scripts (like katakana or hiragana) should be safe in some cases as long that those scripts don't include symbols that can cause confusion for being too similar. I know a few scripts that should be safe to support: * Katakana (Japanese) * Hiragana (Japanese) * Hangul (Korean - `U+115F` and `U+1160` might cause problems, though) * Cyrilic (Russian, etc.) * Greek But not all scripts are safe or should be supported. For instance, the unicode CJK (unified Chinese, Japanese, Korean) contains lots of characters that can easily be confused with others, like full and half-width versions, different types of dot (e.g. º), different letter-like symbols, etc. The same goes with the Latin scripts variants like "áàäâã", etc. These validations are currently taken from Macaron: https://github.com/go-gitea/gitea/blob/4cb1bdddc88580d20305415869d4c13827097bd9/vendor/gitea.com/macaron/binding/binding.go#L268-L272 And used here: https://github.com/go-gitea/gitea/blob/4cb1bdddc88580d20305415869d4c13827097bd9/modules/structs/org_team.go#L20-L40 However, if we decide to support any of this, either we restrict the extended support to a reduced set of "easy" scripts, or we need a profound analysis of the impact of such modification.

GiteaMirror commented

2025-11-02 05:29:45 -06:00

@worthy7 commented on GitHub (Sep 4, 2019):

If it's complicated then it's probably not worth s big change, instead just
charge the error message to tell the truth :-)

On Wed, 4 Sep 2019, 20:58 guillep2k, notifications@github.com wrote:

Here the problem is not the chōonpu character (ー), but the fact that
you're trying to use katakana.

This is more difficult a problem than it may seem.

Currently, team names follow the same or similar rules as for
organizations or repositories, which restricts to use only ASCII
characters: letters, numbers, _, - and in some cases, . too. However,
teams are not bound to file-system resources, so accepting other scripts
(like katakana or hiragana) should be safe in some cases as long that those
scripts don't include symbols that can cause confusion for being too
similar. I know a few scripts that should be safe to support:

Katakana (Japanese)

Hiragana (Japanese)

Hangul (Korean - U+115F and U+1160 might cause problems, though)

Cyrilic (Russian, etc.)

Greek

But not all scripts are safe or should be supported. For instance, the
unicode CJK (unified Chinese, Japanese, Korean) contains lots of characters
that can easily be confused with others, like full and half-width versions,
different types of dot (e.g. º), different letter-like symbols, etc. The
same goes with the Latin scripts variants like "áàäâã", etc.

These validations are currently taken from Macaron:

4cb1bdddc8/vendor/gitea.com/macaron/binding/binding.go (L268-L272)

And used here:

4cb1bdddc8/modules/structs/org_team.go (L20-L40)

However, if we decide to support any of this, either we restrict the
extended support to a reduced set of "easy" scripts, or we need a profound
analysis of the impact of such modification.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/go-gitea/gitea/issues/8077?email_source=notifications&email_token=ABEKWHYWQSMSZRECCSNT3R3QH6PFZA5CNFSM4ITNMQY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53KG7A#issuecomment-527868796,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABEKWH22DQISJFEBUCY7XQLQH6PFZANCNFSM4ITNMQYQ
.

@worthy7 commented on GitHub (Sep 4, 2019): If it's complicated then it's probably not worth s big change, instead just charge the error message to tell the truth :-) On Wed, 4 Sep 2019, 20:58 guillep2k, <notifications@github.com> wrote: > Here the problem is not the chōonpu character (ー), but the fact that > you're trying to use katakana. > > This is more difficult a problem than it may seem. > > Currently, team names follow the same or similar rules as for > organizations or repositories, which restricts to use only ASCII > characters: letters, numbers, _, - and in some cases, . too. However, > teams are not bound to file-system resources, so accepting other scripts > (like katakana or hiragana) should be safe in some cases as long that those > scripts don't include symbols that can cause confusion for being too > similar. I know a few scripts that should be safe to support: > > - Katakana (Japanese) > - Hiragana (Japanese) > - Hangul (Korean - U+115F and U+1160 might cause problems, though) > - Cyrilic (Russian, etc.) > - Greek > > But not all scripts are safe or should be supported. For instance, the > unicode CJK (unified Chinese, Japanese, Korean) contains lots of characters > that can easily be confused with others, like full and half-width versions, > different types of dot (e.g. º), different letter-like symbols, etc. The > same goes with the Latin scripts variants like "áàäâã", etc. > > These validations are currently taken from Macaron: > > https://github.com/go-gitea/gitea/blob/4cb1bdddc88580d20305415869d4c13827097bd9/vendor/gitea.com/macaron/binding/binding.go#L268-L272 > > And used here: > > https://github.com/go-gitea/gitea/blob/4cb1bdddc88580d20305415869d4c13827097bd9/modules/structs/org_team.go#L20-L40 > > However, if we decide to support any of this, either we restrict the > extended support to a reduced set of "easy" scripts, or we need a profound > analysis of the impact of such modification. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/go-gitea/gitea/issues/8077?email_source=notifications&email_token=ABEKWHYWQSMSZRECCSNT3R3QH6PFZA5CNFSM4ITNMQY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53KG7A#issuecomment-527868796>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABEKWH22DQISJFEBUCY7XQLQH6PFZANCNFSM4ITNMQYQ> > . >

GiteaMirror commented

2025-11-02 05:29:45 -06:00

@guillep2k commented on GitHub (Sep 4, 2019):

@Worthy7 But the error message is correct: alphanumeric characters.

@guillep2k commented on GitHub (Sep 4, 2019): @Worthy7 But the error message is correct: alphanumeric characters.

GiteaMirror commented

2025-11-02 05:29:45 -06:00

@worthy7 commented on GitHub (Sep 5, 2019):

So it does lol. Ok, I guess we'll just use English then. For more difficult words (like operations, stake-holders) I think this is a bit "annoying" basically for non-natives.

@worthy7 commented on GitHub (Sep 5, 2019): So it does lol. Ok, I guess we'll just use English then. For more difficult words (like operations, stake-holders) I think this is a bit "annoying" basically for non-natives.

GiteaMirror referenced this issue

2025-11-02 12:26:57 -06:00

[PR #3890] [MERGED] Issue due date api #17128

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#3890