github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 04:42:51 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

serviceworker causes basic auth dialog to not show on subsequent visits #3882

New Issue
Open
opened 2025-11-02 05:29:27 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 05:29:27 -06:00
Owner
Copy Link

Originally created by @peterholak on GitHub (Sep 2, 2019).

Affects all versions since the serviceworker was introduced presumably, including 1.10.0+dev-232-gf1c414882.

Problem:

  • Run gitea behind any kind of reverse proxy (e.g. nginx) with configured basic auth (in nginx).
  • Visit it in browser - the auth dialog will be displayed, enter credentials.
  • Close the browser.
  • Reopen the browser, visit the page again.
  • It shows the "401 Unauthorized" page, without displaying the basic auth dialog - even though the WWW-Authenticate header was sent. In Chrome, refreshing the page with F5 doesn't work. Only pressing Ctrl+Shift+R (not possible on mobile obviously) causes the auth dialog to pop up again.

Seems to be related to the PWA / service worker feature. There is plenty of info on this issue on the web, googling serviceworker basic auth shows many relevant results.

Older versions of gitea (tested with 1.6, see below) didn't suffer from this problem, due to not having the PWA feature.

The issue can be reproduced by using the docker-compose file at https://gist.github.com/peterholak/317f4ca1827672aa231c7114a19149b5. After running docker-compose up, the page at localhost:8004 (latest version of gitea from docker hub) suffers from the described problem, while the page at localhost:8005 (version 1.6) does not. (The credentials are user hello, password world.)

If this is not easy to solve, it would be nice to at least be able to disable the PWA in config.

Originally created by @peterholak on GitHub (Sep 2, 2019). Affects all versions since the serviceworker was introduced presumably, including `1.10.0+dev-232-gf1c414882`. Problem: - Run gitea behind any kind of reverse proxy (e.g. nginx) with configured basic auth (in nginx). - Visit it in browser - the auth dialog will be displayed, enter credentials. - Close the browser. - Reopen the browser, visit the page again. - It shows the "401 Unauthorized" page, without displaying the basic auth dialog - even though the `WWW-Authenticate` header was sent. In Chrome, refreshing the page with `F5` doesn't work. Only pressing `Ctrl+Shift+R` (not possible on mobile obviously) causes the auth dialog to pop up again. Seems to be related to the PWA / service worker feature. There is plenty of info on this issue on the web, googling `serviceworker basic auth` shows many relevant results. Older versions of gitea (tested with 1.6, see below) didn't suffer from this problem, due to not having the PWA feature. The issue can be reproduced by using the docker-compose file at https://gist.github.com/peterholak/317f4ca1827672aa231c7114a19149b5. After running `docker-compose up`, the page at `localhost:8004` (latest version of gitea from docker hub) suffers from the described problem, while the page at `localhost:8005` (version 1.6) does not. (The credentials are user `hello`, password `world`.) If this is not easy to solve, it would be nice to at least be able to disable the PWA in config.
GiteaMirror added the type/proposaltype/enhancement labels 2025-11-02 05:29:27 -06:00
GiteaMirror commented 2025-11-02 05:29:27 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Sep 3, 2019):

PWA should be allowed to be disabled by user.

@lunny commented on GitHub (Sep 3, 2019): PWA should be allowed to be disabled by user.
GiteaMirror commented 2025-11-02 05:29:28 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (May 22, 2020):

Please retest on master, it might be fixed because the new serviceworker implementation intercepts less.

@silverwind commented on GitHub (May 22, 2020): Please retest on master, it might be fixed because the new serviceworker implementation intercepts less.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/enhancement type/proposal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?