Show prominent warning and howto in user and admin interfaces when user-initiated password reset is impossible #3863

New Issue

GiteaMirror · 2025-11-02T05:28:48-06:00

GiteaMirror commented

2025-11-02 05:28:48 -06:00

Originally created by @Poikilos on GitHub (Aug 28, 2019).

Gitea version (or commit ref): 1.9.2 (Go1.12.9)
Database (use [x]): unknown (admin unavailable)
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist: N/A

Description

User-initiated reset says it is disabled, when in reality, e-mail is probably not configured, according to comments at https://github.com/go-gitea/gitea/issues/2247 which is closed for unknown reasons which the closer did not describe.

Expected behavior:

Provide warning message such as proposed by jolheiser. Whereas "disabled" is misleading (according to replies at which indicate that the message only appears when e-mail is not configured and that there is no setting for it), "disabled because e-mail is not configured" (maybe that on that admin side, and something like "is not configured" on the user side) would be more clear, and would point to the solution.
Where the warning is shown prominently, also explain how to correct the issue (at least on the admin side).

Originally created by @Poikilos on GitHub (Aug 28, 2019). - Gitea version (or commit ref): 1.9.2 (Go1.12.9) - Database (use `[x]`): unknown (admin unavailable) - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: N/A ## Description User-initiated reset says it is disabled, when in reality, e-mail is probably not configured, according to comments at https://github.com/go-gitea/gitea/issues/2247 which is closed for unknown reasons which the closer did not describe. Expected behavior: - Provide warning message such as [proposed by jolheiser](https://github.com/go-gitea/gitea/issues/2247#issuecomment-513620841). Whereas "disabled" is misleading (according to replies at which indicate that the message only appears when e-mail is not configured and that there is **no setting for it**), "disabled because e-mail is not configured" (maybe that on that admin side, and something like "is not configured" on the user side) would be more clear, and would point to the solution. - Where the warning is shown prominently, also explain how to correct the issue (at least on the admin side). ![image](https://user-images.githubusercontent.com/7557867/63882077-43716a00-c99f-11e9-9756-b06c658597a6.png)

GiteaMirror added the topic/ui type/proposal labels 2025-11-02 05:28:48 -06:00

GiteaMirror closed this issue

2025-11-02 05:28:49 -06:00

GiteaMirror commented

2025-11-02 05:28:49 -06:00

@jolheiser commented on GitHub (Jun 26, 2021):

Fixed by #15117, which shows a better error to admin as well as logging a warning when that page is shown (so an admin looking for something in logs can maybe still find it)

@jolheiser commented on GitHub (Jun 26, 2021): Fixed by #15117, which shows a better error to admin as well as logging a warning when that page is shown (so an admin looking for something in logs can maybe still find it)

GiteaMirror referenced this issue

2025-11-02 12:26:35 -06:00

[PR #3863] [MERGED] Switch back to upstream goth repository and update govendor to latest goth version #17112

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#3863