mirror of
https://github.com/go-gitea/gitea.git
synced 2026-03-12 10:39:38 -05:00
link to create PR after push is missing after update from 1.8 to 1.9 on existing repos #3859
Closed
opened 2025-11-02 05:28:36 -06:00 by GiteaMirror
·
29 comments
No Branch/Tag Specified
main
release/v1.25
release/v1.24
release/v1.23
release/v1.22
release/v1.21
release/v1.20
release/v1.19
release/v1.18
release/v1.17
release/v1.16
release/v1.15
release/v1.14
release/v1.13
release/v1.12
release/v1.11
release/v1.10
release/v1.9
release/v1.8
v1.25.3
v1.25.2
v1.25.1
v1.25.0
v1.24.7
v1.25.0-rc0
v1.26.0-dev
v1.24.6
v1.24.5
v1.24.4
v1.24.3
v1.24.2
v1.24.1
v1.24.0
v1.23.8
v1.24.0-rc0
v1.25.0-dev
v1.23.7
v1.23.6
v1.23.5
v1.23.4
v1.23.3
v1.23.2
v1.23.1
v1.23.0
v1.23.0-rc0
v1.24.0-dev
v1.22.6
v1.22.5
v1.22.4
v1.22.3
v1.22.2
v1.22.1
v1.22.0
v1.23.0-dev
v1.22.0-rc1
v1.21.11
v1.22.0-rc0
v1.21.10
v1.21.9
v1.21.8
v1.21.7
v1.21.6
v1.21.5
v1.21.4
v1.21.3
v1.21.2
v1.20.6
v1.21.1
v1.21.0
v1.21.0-rc2
v1.21.0-rc1
v1.20.5
v1.22.0-dev
v1.21.0-rc0
v1.20.4
v1.20.3
v1.20.2
v1.20.1
v1.20.0
v1.19.4
v1.21.0-dev
v1.20.0-rc2
v1.20.0-rc1
v1.20.0-rc0
v1.19.3
v1.19.2
v1.19.1
v1.19.0
v1.19.0-rc1
v1.20.0-dev
v1.19.0-rc0
v1.18.5
v1.18.4
v1.18.3
v1.18.2
v1.18.1
v1.18.0
v1.17.4
v1.18.0-rc1
v1.19.0-dev
v1.18.0-rc0
v1.17.3
v1.17.2
v1.17.1
v1.17.0
v1.17.0-rc2
v1.16.9
v1.17.0-rc1
v1.18.0-dev
v1.16.8
v1.16.7
v1.16.6
v1.16.5
v1.16.4
v1.16.3
v1.16.2
v1.16.1
v1.16.0
v1.15.11
v1.17.0-dev
v1.16.0-rc1
v1.15.10
v1.15.9
v1.15.8
v1.15.7
v1.15.6
v1.15.5
v1.15.4
v1.15.3
v1.15.2
v1.15.1
v1.14.7
v1.15.0
v1.15.0-rc3
v1.14.6
v1.15.0-rc2
v1.14.5
v1.16.0-dev
v1.15.0-rc1
v1.14.4
v1.14.3
v1.14.2
v1.14.1
v1.14.0
v1.13.7
v1.14.0-rc2
v1.13.6
v1.13.5
v1.14.0-rc1
v1.15.0-dev
v1.13.4
v1.13.3
v1.13.2
v1.13.1
v1.13.0
v1.12.6
v1.13.0-rc2
v1.14.0-dev
v1.13.0-rc1
v1.12.5
v1.12.4
v1.12.3
v1.12.2
v1.12.1
v1.11.8
v1.12.0
v1.11.7
v1.12.0-rc2
v1.11.6
v1.12.0-rc1
v1.13.0-dev
v1.11.5
v1.11.4
v1.11.3
v1.10.6
v1.12.0-dev
v1.11.2
v1.10.5
v1.11.1
v1.10.4
v1.11.0
v1.11.0-rc2
v1.10.3
v1.11.0-rc1
v1.10.2
v1.10.1
v1.10.0
v1.9.6
v1.9.5
v1.10.0-rc2
v1.11.0-dev
v1.10.0-rc1
v1.9.4
v1.9.3
v1.9.2
v1.9.1
v1.9.0
v1.9.0-rc2
v1.10.0-dev
v1.9.0-rc1
v1.8.3
v1.8.2
v1.8.1
v1.8.0
v1.8.0-rc3
v1.7.6
v1.8.0-rc2
v1.7.5
v1.8.0-rc1
v1.9.0-dev
v1.7.4
v1.7.3
v1.7.2
v1.7.1
v1.7.0
v1.7.0-rc3
v1.6.4
v1.7.0-rc2
v1.6.3
v1.7.0-rc1
v1.7.0-dev
v1.6.2
v1.6.1
v1.6.0
v1.6.0-rc2
v1.5.3
v1.6.0-rc1
v1.6.0-dev
v1.5.2
v1.5.1
v1.5.0
v1.5.0-rc2
v1.5.0-rc1
v1.5.0-dev
v1.4.3
v1.4.2
v1.4.1
v1.4.0
v1.4.0-rc3
v1.4.0-rc2
v1.3.3
v1.4.0-rc1
v1.3.2
v1.3.1
v1.3.0
v1.3.0-rc2
v1.3.0-rc1
v1.2.3
v1.2.2
v1.2.1
v1.2.0
v1.2.0-rc3
v1.2.0-rc2
v1.1.4
v1.2.0-rc1
v1.1.3
v1.1.2
v1.1.1
v1.1.0
v1.0.2
v1.0.1
v1.0.0
v0.9.99
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
Mirrored from GitHub Pull Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/gitea#3859
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @morph027 on GitHub (Aug 28, 2019).
[x]):This is the server side log when pushing a branch:
My local shell just gives:
Description
Today i've managed to update Gitea from 1.8.2 to 1.9.2 and after pushing a new branch, i'm missing the remote message to create a new PR introduced in #4716
@morph027 commented on GitHub (Aug 28, 2019):
Created a new org repo, forked into my user and pushed a branch and the beloved magic link is there...will check the repo hook settings...
@morph027 commented on GitHub (Aug 28, 2019):
When deleting a fork of a non-working repo and creating a new fork, the link also appears after pushing a new branch.
@lafriks commented on GitHub (Aug 28, 2019):
From admin settings run

Resynchronize pre-receive, update and post-receive hooks of all repositories.task:@morph027 commented on GitHub (Aug 29, 2019):
Nothing changed. Looking at the filesystem, all projects got the same hooks (the initial bash script which loops over all hooks in .d directory and the gitea hook call in .d directory).
Not sure where the hook gets lost. Will try to enable more debug output and see, if i can find something related.
@morph027 commented on GitHub (Sep 6, 2019):
Also weird, we still got repos which are working without re-fork (in another organisation).
@morph027 commented on GitHub (Sep 6, 2019):
comparing a fresh fork (
user1, where it's working) against a non-working fork (user2):No difference.
@guillep2k commented on GitHub (Sep 7, 2019):
Perhaps some users are using VS2019? In my VS2019 I'm not getting the remote messages in the
Source Control - Gitlog, but I do get them if I use git from bash.@morph027 commented on GitHub (Sep 7, 2019):
Nayh, just using command line ;)
@lunny commented on GitHub (Sep 15, 2019):
@guillep2k the push link is more efficient than VS2019 I think. You can just click that link and create a PR in seconds.
@stale[bot] commented on GitHub (Nov 14, 2019):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
@zeripath commented on GitHub (Nov 14, 2019):
@morph027 are you sure that the hooks are even running? If your SSH key isn't managed by Gitea i.e. you can log in to the server to a shell then the hooks won't run because the environment won't get set because gitea serv won't get run.
As part of 1.11 I might pop a PR on that enforces pushes to Gitea repos have to be done in such a way that the hooks will run properly.
@morph027 commented on GitHub (Nov 14, 2019):
The SSH key is managed through Gitea Webinterface.
@zeripath commented on GitHub (Nov 14, 2019):
Yeah sorry just reading your logs - I can see that the hooks are running.
OK, so does your test repository have another branch or is that the first commit - because if it is the first commit and you have no other branches it will get set as the default branch after you push it - hence no pr message.
@morph027 commented on GitHub (Nov 14, 2019):
This happens on all existing projects which did have the PR message before the update...
@zeripath commented on GitHub (Nov 14, 2019):
OK let's look at the logic.
The create a PR logic is in the post-receive hook and is determined by
gitea hook post-receivehere:2f73fff053/cmd/hook.go (L175-L181)I.e the result from the pushing of a branch is
res["create"] = true.That's determined by here:
2f73fff053/routers/private/hook.go (L173-L240)The important parts are:
2f73fff053/routers/private/hook.go (L173)I.e. you're pushing the creation of a branch not deleting it.
2f73fff053/routers/private/hook.go (L185)I.e. the user is allowed to create PRs
2f73fff053/routers/private/hook.go (L204)i.e. the branch being pushed to is not the default branch - this is the problem with your testcase.
2f73fff053/routers/private/hook.go (L221)i.e. There is not already a PR for this branch
@zeripath commented on GitHub (Nov 14, 2019):
In 1.8 the logic was determined by:
11f6ed4f83/cmd/hook.go (L210-L248)The important parts are:
11f6ed4f83/cmd/hook.go (L210)11f6ed4f83/cmd/hook.go (L217)11f6ed4f83/cmd/hook.go (L226)11f6ed4f83/cmd/hook.go (L237)@zeripath commented on GitHub (Nov 14, 2019):
The only difference I can see between 1.8 and 1.9 is that your testcase will "work" in 1.8 because 1.8 will not set the default branch to be the first thing that is pushed.
@zeripath commented on GitHub (Nov 14, 2019):
Are there definitely no errors in your logs? That's the only other way there could be a difference.
@morph027 commented on GitHub (Nov 14, 2019):
Any logs in particular? Should i set loglevel to trace?
@zeripath commented on GitHub (Nov 14, 2019):
If you look at the code I've put up above for 1.9, all the points that would cause no output
log.Errorexcept for the case that you are pushing to the defaultBranch of a non-fork which doesn't log.If you are pushing a non-default branch that you should either get a create the branch or visit the branch message. Compare the code between 1.8 and 1.9 I can't see how there could be a difference.
@stale[bot] commented on GitHub (Jan 13, 2020):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
@morph027 commented on GitHub (Jan 13, 2020):
Huh, already forgot about ;)
We've upgraded to 1.10.2 recently and the behaviour still exists.
@zeripath commented on GitHub (Jan 14, 2020):
Maybe it's the determination of isPullRequest allowed? As I wrote above the hook change I don't think can be the cause
@stale[bot] commented on GitHub (Mar 14, 2020):
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.
@morph027 commented on GitHub (Mar 25, 2020):
Now running 1.11.3, even with
PULL_REQUEST_PUSH_MESSAGE = truethere's no consistent behaviour. Some forks are working, some not.@zeripath commented on GitHub (Mar 28, 2020):
OK can you tell me anything about the cases where this doesn't work? I'm gonna put a guess out here:
Another question are the original forked repos are using an external issue tracker?
@morph027 commented on GitHub (Mar 30, 2020):
Hi!
Yes, both is true, all of our repos are forks of an organisation upstream and the upstreams are limited. Creating a PR through the webinterface works without problems.
At least in my case, i'm in the owners groups of the orgs.
And there are repos within the same organisation, where everything works.
None of the repos is using an external issue tracker.
@stale[bot] commented on GitHub (May 30, 2020):
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.
@stale[bot] commented on GitHub (Jun 13, 2020):
This issue has been automatically closed because of inactivity. You can re-open it if needed.