github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-13 02:57:44 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

RocketChat notification for pull request comment has not working hyperlink #3841

New Issue
Closed
opened 2025-11-02 05:27:52 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 05:27:52 -06:00
Owner
Copy Link

Originally created by @mathysie on GitHub (Aug 25, 2019).

  • Gitea version (or commit ref): 1.9.2
  • Git version:
  • Operating system: Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

After placing a comment in a pull request, a notification is send to our Rocket.Chat. The notification tries to provide a hyperlink to the message with the syntax <"hyperlink"|"name pull request">. This is correct, however it is used as a header as well. Therefore, instead of making a hyperlink to the Gitea server, Rocket.Chat creates a hyperlink to show the contents of the comment.

I suggest to change the comment notification to:

[foo] New comment created by <"hyperlink to user"|"user">: <"hyperlink to comment"|"name pull request">
> "Comment contents"

This method will render all hyperlinks correctly.

Screenshots

Schermafdruk van 2019-08-25 14-11-30

Originally created by @mathysie on GitHub (Aug 25, 2019). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 1.9.2 - Git version: - Operating system: Ubuntu 18.04 - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description After placing a comment in a pull request, a notification is send to our Rocket.Chat. The notification tries to provide a hyperlink to the message with the syntax `<"hyperlink"|"name pull request">`. This is correct, however it is used as a header as well. Therefore, instead of making a hyperlink to the Gitea server, Rocket.Chat creates a hyperlink to show the contents of the comment. I suggest to change the comment notification to: ``` [foo] New comment created by <"hyperlink to user"|"user">: <"hyperlink to comment"|"name pull request"> > "Comment contents" ``` This method will render all hyperlinks correctly. ## Screenshots ![Schermafdruk van 2019-08-25 14-11-30](https://user-images.githubusercontent.com/26286382/63649956-b3d07f00-c744-11e9-89bb-da3b37158562.png) <!-- **If this issue involves the Web Interface, please include a screenshot** -->
GiteaMirror added the issue/confirmedtype/bug labels 2025-11-02 05:27:53 -06:00
GiteaMirror commented 2025-11-02 05:27:54 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 25, 2019):

Which webhook type did you use?

@lunny commented on GitHub (Aug 25, 2019): Which webhook type did you use?
GiteaMirror commented 2025-11-02 05:27:54 -06:00
Author
Owner
Copy Link

@mathysie commented on GitHub (Aug 25, 2019):

We are using the slack hook

@mathysie commented on GitHub (Aug 25, 2019): We are using the slack hook
GiteaMirror commented 2025-11-02 05:27:54 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Oct 24, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Oct 24, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 05:27:55 -06:00
Author
Owner
Copy Link

@cornelk commented on GitHub (Jan 5, 2020):

@mathysie please test again with v1.10.2 or later, this should be fixed with https://github.com/go-gitea/gitea/pull/9422

@cornelk commented on GitHub (Jan 5, 2020): @mathysie please test again with v1.10.2 or later, this should be fixed with https://github.com/go-gitea/gitea/pull/9422
GiteaMirror commented 2025-11-02 05:27:55 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Jan 5, 2020):

Closing as fixed, reopen if there is still a problem

@lafriks commented on GitHub (Jan 5, 2020): Closing as fixed, reopen if there is still a problem
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3841
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?