github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Bad default commit message of file upload in root directory #3794

New Issue
Closed
opened 2025-11-02 05:25:26 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 05:25:26 -06:00
Owner
Copy Link

Originally created by @noerw on GitHub (Aug 15, 2019).

Description

Uploading a file and not entering a commit message results in a commit message like Uploaded files to '<dir>'.
When files are uploaded to the root directory, the content inside the quotes is empty.

Screenshots

image

Originally created by @noerw on GitHub (Aug 15, 2019). - Gitea version (or commit ref):1.9.1 - Git version: 2.21.0 - Operating system: fedora 30 - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes https://try.gitea.io/norwin/test/src/branch/master/ - [ ] No - [ ] Not relevant - Log gist: ## Description Uploading a file and not entering a commit message results in a commit message like `Uploaded files to '<dir>'`. When files are uploaded to the root directory, the content inside the quotes is empty. ## Screenshots ![image](https://user-images.githubusercontent.com/7880552/63121826-e46e2700-bf94-11e9-9744-b7d6f0d1b97f.png)
GiteaMirror added the issue/confirmedtopic/uitype/bug labels 2025-11-02 05:25:26 -06:00
GiteaMirror commented 2025-11-02 05:25:28 -06:00
Author
Owner
Copy Link

@lafriks commented on GitHub (Aug 29, 2019):

any suggestions on what it should be?

@lafriks commented on GitHub (Aug 29, 2019): any suggestions on what it should be?
GiteaMirror commented 2025-11-02 05:25:28 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (Oct 28, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Oct 28, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 05:25:28 -06:00
Author
Owner
Copy Link

@fnetX commented on GitHub (May 14, 2021):

Upload files to '/' sounds better. (Just generally adding a / before the var). Or, setting it to
Upload files to root (without quotes to differ from "root" dir), but this would probably require more than changing one line ...

@fnetX commented on GitHub (May 14, 2021): `Upload files to '/'` sounds better. (Just generally adding a / before the var). Or, setting it to `Upload files to root` (without quotes to differ from "root" dir), but this would probably require more than changing one line ...
GiteaMirror commented 2025-11-02 05:25:28 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (May 14, 2021):

@fnetX that seems simplest. Fancy putting the fix in? It's likely a template issue.

@zeripath commented on GitHub (May 14, 2021): @fnetX that seems simplest. Fancy putting the fix in? It's likely a template issue.
GiteaMirror commented 2025-11-02 05:25:28 -06:00
Author
Owner
Copy Link

@fnetX commented on GitHub (May 15, 2021):

It's a translation thing.
editor.upload_files_to_dir = Upload files to '%s'
Should I somehow add the / to the string that is inserted there and hope it doesn't break, or update the locales? If the latter, how does this work? I've only been working as a translator so far, not as someone that changes the original string ...

@fnetX commented on GitHub (May 15, 2021): It's a translation thing. `editor.upload_files_to_dir = Upload files to '%s'` Should I somehow add the / to the string that is inserted there and hope it doesn't break, or update the locales? If the latter, how does this work? I've only been working as a translator so far, not as someone that changes the original string ...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed topic/ui type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?