Local instance of gitea don`t display images. #374

@Lourens-Rich commented on GitHub (Feb 21, 2017):

Repo on try.gitea.io have 500 error. (https://try.gitea.io/Lourens-Rich/markdown-image-bug)

Also, i uploaded copy of this repo here: https://git.r208.tk/Lourens-Rich/markdown-image-bug

@Lourens-Rich commented on GitHub (Feb 21, 2017): Repo on try.gitea.io have 500 error. (https://try.gitea.io/Lourens-Rich/markdown-image-bug) Also, i uploaded copy of this repo here: https://git.r208.tk/Lourens-Rich/markdown-image-bug

GiteaMirror commented

@lunny commented on GitHub (Feb 21, 2017):

it's duplicated with #988 and we have a PR #993 to fix this.

@lunny commented on GitHub (Feb 21, 2017): it's duplicated with #988 and we have a PR #993 to fix this.

GiteaMirror commented

@lunny commented on GitHub (Feb 21, 2017):

About the 500 error, could you fire another issue? Thanks!

@lunny commented on GitHub (Feb 21, 2017): About the 500 error, could you fire another issue? Thanks!

GiteaMirror commented

@Lourens-Rich commented on GitHub (Feb 21, 2017):

I transform this issue to my another problem.

@Lourens-Rich commented on GitHub (Feb 21, 2017): I transform this issue to my another problem.

GiteaMirror commented

@Lourens-Rich commented on GitHub (Feb 21, 2017):

@lunny, please reopen it.

@Lourens-Rich commented on GitHub (Feb 21, 2017): @lunny, please reopen it.

GiteaMirror commented

@lunny commented on GitHub (Feb 21, 2017):

OK. Please change your issue content also.

@lunny commented on GitHub (Feb 21, 2017): OK. Please change your issue content also.

GiteaMirror commented

@Lourens-Rich commented on GitHub (Feb 22, 2017):

Cast @lunny. Updated post and approved the problem on try.gitea.org.

@Lourens-Rich commented on GitHub (Feb 22, 2017): Cast @lunny. Updated post and approved the problem on try.gitea.org.

GiteaMirror commented

@lunny commented on GitHub (Feb 22, 2017):

@andrew-boyarshin could you see this issue? I think maybe it's related with the markdown render.

@lunny commented on GitHub (Feb 22, 2017): @andrew-boyarshin could you see this issue? I think maybe it's related with the markdown render.

GiteaMirror commented

@andrew-boyarshin commented on GitHub (Feb 22, 2017):

@lunny in progress... The comment will be updated.

Definitely bug, most likely related to my PR.

UPD: Path not combined correctly. The problem is with markdown.go:L214, url.QueryEscape.

UPD: Fixed locally by reverting change in my PR, with a couple of additional fixes to URLJoin. Improved test coverage.

UPD: I am now trying to clone this repo and try out the result.

UPD: PR is to be created. Bug fixed.

UPD: Looks like the bug was too huge. I underestimated it. It was caused by too complicated structure of file retrieval. Work in progress. Another large PR is to be expected.

UPD: I managed to narrow the set of required changes to a relatively small amount. Plus, I managed to fix wrong behavior of commit and issue URLs rewrite introduced in my PR.

UPD: Internal code review in progress.

UPD: PR submitted.

@andrew-boyarshin commented on GitHub (Feb 22, 2017): @lunny in progress... _The comment will be updated._ Definitely bug, most likely related to my PR. UPD: Path not combined correctly. The problem is with [markdown.go:L214](https://github.com/go-gitea/gitea/blob/master/modules/markdown/markdown.go#L214), url.QueryEscape. UPD: Fixed locally by reverting change in my PR, with a couple of additional fixes to URLJoin. Improved test coverage. UPD: I am now trying to clone this repo and try out the result. UPD: PR is to be created. Bug fixed. UPD: Looks like the bug was too huge. I underestimated it. It was caused by too complicated structure of file retrieval. Work in progress. Another large PR is to be expected. UPD: I managed to narrow the set of required changes to a relatively small amount. Plus, I managed to fix wrong behavior of commit and issue URLs rewrite introduced in my PR. UPD: Internal code review in progress. UPD: PR submitted.

GiteaMirror commented

@andrew-boyarshin commented on GitHub (Feb 24, 2017):

This is fixed now by #1027. Confirmed to be working correctly: https://try.gitea.io/Lourens-Rich/markdown-image-bug/src/master/2017/02/note.md. You can close the issue now.

@andrew-boyarshin commented on GitHub (Feb 24, 2017): This is fixed now by #1027. Confirmed to be working correctly: <https://try.gitea.io/Lourens-Rich/markdown-image-bug/src/master/2017/02/note.md>. You can close the issue now.

GiteaMirror commented

@Lourens-Rich commented on GitHub (Feb 25, 2017):

Wow! Great! @andrew-boyarshin, thank you brother, thank you!

@Lourens-Rich commented on GitHub (Feb 25, 2017): Wow! Great! @andrew-boyarshin, thank you brother, thank you!

GiteaMirror commented

@kiemrong08 commented on GitHub (Aug 13, 2018):

I can't display image in markdown.
https://try.gitea.io/kiemrong08/testimage/src/branch/master/README.md

@kiemrong08 commented on GitHub (Aug 13, 2018): I can't display image in markdown. https://try.gitea.io/kiemrong08/testimage/src/branch/master/README.md

GiteaMirror commented