[Branch View] protected symbol shows up unintended when not logged in #3652

Closed
opened 2025-11-02 05:20:36 -06:00 by GiteaMirror · 6 comments
Owner

Originally created by @6543 on GitHub (Jul 23, 2019).

branches shows protected symbol if you arent signt in.

if you are loged in protected symbol is on corect places only (doesnt mather if you only have read or wirte permissions)

Originally created by @6543 on GitHub (Jul 23, 2019). branches shows protected symbol if you arent signt in. if you are loged in protected symbol is on corect places only (doesnt mather if you only have read or wirte permissions)
GiteaMirror added the type/bug label 2025-11-02 05:20:36 -06:00
Author
Owner

@gary-kim commented on GitHub (Jul 23, 2019):

There does seem to be a bug where the branches page will indicate that all branches are protected whether or not they are actually protected branches.

The branches page shows the correct protected statuses on branches when logged in.

@gary-kim commented on GitHub (Jul 23, 2019): There does seem to be a bug where the branches page will indicate that all branches are protected whether or not they are actually protected branches. The branches page shows the correct protected statuses on branches when logged in.
Author
Owner

@6543 commented on GitHub (Jul 30, 2019):

i think this is a bug in the go code (server side)

@6543 commented on GitHub (Jul 30, 2019): i think this is a bug in the go code (server side)
Author
Owner

@6543 commented on GitHub (Jul 30, 2019):

Error Preview:

with login

login

without login

no login

@6543 commented on GitHub (Jul 30, 2019): # Error Preview: ## with login ![login](https://ipfs.io/ipfs/QmawScNMXW1c7CPE39icXyeHDTKjrMBeMLvA8fvLHKGkmA) ## without login ![no login](https://www.bilder-upload.eu/upload/35d060-1564449973.png)
Author
Owner

@lunny commented on GitHub (Jul 30, 2019):

This should be resolved by https://github.com/go-gitea/gitea/pull/7674

@lunny commented on GitHub (Jul 30, 2019): This should be resolved by https://github.com/go-gitea/gitea/pull/7674
Author
Owner

@6543 commented on GitHub (Jul 30, 2019):

no it is not :(
is it fixed at your test instance? @lunny
i tested master (d974c139b4)

@6543 commented on GitHub (Jul 30, 2019): no it is not :( is it fixed at your test instance? @lunny i tested master (d974c139b4a87a86254b3e4660b131152923f083)
Author
Owner

@lunny commented on GitHub (Jul 31, 2019):

@6543 right. The bug is still there when no login. @techknowlogick

@lunny commented on GitHub (Jul 31, 2019): @6543 right. The bug is still there when no login. @techknowlogick
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3652