When requesting captcha, it will request database. #3560

New Issue

GiteaMirror · 2025-11-02T05:17:20-06:00

GiteaMirror commented

2025-11-02 05:17:20 -06:00

Originally created by @lunny on GitHub (Jul 10, 2019).

2019/07/10 09:51:03 Started GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 for [::1]
2019/07/10 09:51:03 .../xorm/session_get.go:99:nocacheGet() [I] [SQL] SELECT `id`, `lower_name`, `name`, `full_name`, `email`, `keep_email_private`, `passwd`, `passwd_hash_algo`, `must_change_password`, `login_type`, `login_source`, `login_name`, `type`, `location`, `website`, `rands`, `salt`, `language`, `description`, `created_unix`, `updated_unix`, `last_login_unix`, `last_repo_visibility`, `max_repo_creation`, `is_active`, `is_admin`, `allow_git_hook`, `allow_import_local`, `allow_create_organization`, `prohibit_login`, `avatar`, `avatar_email`, `use_custom_avatar`, `num_followers`, `num_following`, `num_stars`, `num_repos`, `num_teams`, `num_members`, `visibility`, `diff_view_style`, `theme` FROM `user` WHERE `lower_name`=? LIMIT 1 []interface {}{"captcha"}
2019/07/10 09:51:03 Completed GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 200 OK in 119.484905ms

When a middleware has written something to ResponseWriter, it should not go to match the URL? Is this a bug of macaron or our wrong configuration?

Originally created by @lunny on GitHub (Jul 10, 2019). ```log 2019/07/10 09:51:03 Started GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 for [::1] 2019/07/10 09:51:03 .../xorm/session_get.go:99:nocacheGet() [I] [SQL] SELECT `id`, `lower_name`, `name`, `full_name`, `email`, `keep_email_private`, `passwd`, `passwd_hash_algo`, `must_change_password`, `login_type`, `login_source`, `login_name`, `type`, `location`, `website`, `rands`, `salt`, `language`, `description`, `created_unix`, `updated_unix`, `last_login_unix`, `last_repo_visibility`, `max_repo_creation`, `is_active`, `is_admin`, `allow_git_hook`, `allow_import_local`, `allow_create_organization`, `prohibit_login`, `avatar`, `avatar_email`, `use_custom_avatar`, `num_followers`, `num_following`, `num_stars`, `num_repos`, `num_teams`, `num_members`, `visibility`, `diff_view_style`, `theme` FROM `user` WHERE `lower_name`=? LIMIT 1 []interface {}{"captcha"} 2019/07/10 09:51:03 Completed GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 200 OK in 119.484905ms ``` When a middleware has written something to ResponseWriter, it should not go to match the URL? Is this a bug of macaron or our wrong configuration?

GiteaMirror added the issue/confirmed type/bug labels 2025-11-02 05:17:20 -06:00

GiteaMirror closed this issue

2025-11-02 05:17:20 -06:00

GiteaMirror commented

2025-11-02 05:17:21 -06:00

@zeripath commented on GitHub (Jul 10, 2019):

Was this fixed by #7407?

@zeripath commented on GitHub (Jul 10, 2019): Was this fixed by #7407?

GiteaMirror commented

2025-11-02 05:17:21 -06:00

@lunny commented on GitHub (Jul 10, 2019):

I think no.

@lunny commented on GitHub (Jul 10, 2019): I think no.

GiteaMirror commented

2025-11-02 05:17:21 -06:00

@stale[bot] commented on GitHub (Sep 8, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Sep 8, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:17:21 -06:00

@lunny commented on GitHub (Sep 10, 2019):

I will check if this is still in v1.10.

@lunny commented on GitHub (Sep 10, 2019): I will check if this is still in v1.10.

GiteaMirror commented

2025-11-02 05:17:21 -06:00

@lunny commented on GitHub (Sep 12, 2019):

This has gone on 1.10.0+dev-277-g5e67e0100

@lunny commented on GitHub (Sep 12, 2019): This has gone on 1.10.0+dev-277-g5e67e0100

GiteaMirror referenced this issue

2025-11-02 11:51:36 -06:00