gitea 1.9.0rc - missing binaries on tagged version #3547

New Issue

GiteaMirror · 2025-11-02T05:16:43-06:00

GiteaMirror commented

2025-11-02 05:16:43 -06:00

Originally created by @Cherrg on GitHub (Jul 8, 2019).

Shouldn't there be some build binaries and changelog on release list?

-> I don't know the whole workflow so I just asked.

drone build failed on tag-test https://drone.gitea.io/go-gitea/gitea/10493/1/11

Originally created by @Cherrg on GitHub (Jul 8, 2019). Shouldn't there be some build binaries and changelog on release list? -> I don't know the whole workflow so I just asked. drone build failed on `tag-test` https://drone.gitea.io/go-gitea/gitea/10493/1/11

GiteaMirror added the topic/build label 2025-11-02 05:16:43 -06:00

GiteaMirror closed this issue

2025-11-02 05:16:43 -06:00

GiteaMirror commented

2025-11-02 05:16:44 -06:00

@mrsdizzie commented on GitHub (Jul 8, 2019):

It has not actually been released yet (per error above)

@mrsdizzie commented on GitHub (Jul 8, 2019): It has not actually been released yet (per error above)

GiteaMirror commented

2025-11-02 05:16:44 -06:00

@lunny commented on GitHub (Jul 8, 2019):

tag-test failed.

@lunny commented on GitHub (Jul 8, 2019): tag-test failed.

GiteaMirror commented

2025-11-02 05:16:44 -06:00

@Cherrg commented on GitHub (Jul 8, 2019):

I tried to reproduce on local machine by make test. Are there some requirements to run those tests?
-> I got more and other error messages

@Cherrg commented on GitHub (Jul 8, 2019): I tried to reproduce on local machine by `make test`. Are there some requirements to run those tests? -> I got more and other error messages

GiteaMirror commented

2025-11-02 05:16:44 -06:00

@lunny commented on GitHub (Jul 8, 2019):

It should not require others.

@lunny commented on GitHub (Jul 8, 2019): It should not require others.

GiteaMirror commented

2025-11-02 05:16:45 -06:00

@techknowlogick commented on GitHub (Jul 8, 2019):

This is the test that fails: edc94c7041/modules/git/repo_test.go (L15)

It fails specifically by calling this function edc94c7041/modules/git/repo.go (L326) which calls CLI git for-each-ref --sort=-committerdate refs/heads/ --count 1 --format=%(committerdate)

I've been able to replicate locally:

mkdir test
cd test
git init
git remote add origin https://github.com/go-gitea/gitea
git fetch origin +refs/tags/v1.9.0-rc1
git for-each-ref --sort=-committerdate refs/heads/ --count 1 --format=%\(committerdate\)

The last command returns `` which on a standard repo clone, or even a repo that has clone depth 200 it'll return a formatted date.

@techknowlogick commented on GitHub (Jul 8, 2019): This is the test that fails: https://github.com/go-gitea/gitea/blob/edc94c70413048107ea728ff330f32ca3de6df88/modules/git/repo_test.go#L15 It fails specifically by calling this function https://github.com/go-gitea/gitea/blob/edc94c70413048107ea728ff330f32ca3de6df88/modules/git/repo.go#L326 which calls CLI `git for-each-ref --sort=-committerdate refs/heads/ --count 1 --format=%(committerdate)` I've been able to replicate locally: ``` mkdir test cd test git init git remote add origin https://github.com/go-gitea/gitea git fetch origin +refs/tags/v1.9.0-rc1 git for-each-ref --sort=-committerdate refs/heads/ --count 1 --format=%\(committerdate\) ``` The last command returns `` which on a standard repo clone, or even a repo that has clone depth 200 it'll return a formatted date.

GiteaMirror commented

2025-11-02 05:16:45 -06:00

@lunny commented on GitHub (Jul 8, 2019):

Yes, it needs a full clone I think but why it didn't fail before maybe because we changed .drone.yml to new format this release.

@lunny commented on GitHub (Jul 8, 2019): Yes, it needs a full clone I think but why it didn't fail before maybe because we changed .drone.yml to new format this release.

GiteaMirror commented

2025-11-02 05:16:45 -06:00

@techknowlogick commented on GitHub (Jul 8, 2019):

It only failed with this tag because we introduced this test since release of 1.8 with merge of other git repo (now stored at modules/git). I don't think a full clone is needed, only something at refs/head so code will have something to reference.

@techknowlogick commented on GitHub (Jul 8, 2019): It only failed with this tag because we introduced this test since release of 1.8 with merge of other git repo (now stored at modules/git). I don't think a full clone is needed, only something at `refs/head` so code will have something to reference.

GiteaMirror commented

2025-11-02 05:16:45 -06:00

@techknowlogick commented on GitHub (Jul 8, 2019):

Ok. I have a solution that I've created a PR.

@techknowlogick commented on GitHub (Jul 8, 2019): Ok. I have a solution that I've created a PR.

GiteaMirror referenced this issue

2025-11-02 12:23:41 -06:00

[PR #3547] [MERGED] refactor: reduce sql query times in retrieveFeeds #16989

Sign in to join this conversation.