Add option to load suppressed diffs #3532

New Issue

GiteaMirror · 2025-11-02T05:16:03-06:00

GiteaMirror commented

2025-11-02 05:16:03 -06:00

Originally created by @silverwind on GitHub (Jul 2, 2019).

Currently if a diff is suppressed because it's too large there is no way to load it like GitHub does:

Gitea:

GitHub:

Originally created by @silverwind on GitHub (Jul 2, 2019). Currently if a diff is suppressed because it's too large there is no way to load it like GitHub does: Gitea: <img width="1152" alt="Screenshot 2019-07-02 at 10 23 19" src="https://user-images.githubusercontent.com/115237/60496689-a0a8b200-9cb3-11e9-8f6c-72289ce07ef7.png"> GitHub: <img width="1203" alt="Screenshot 2019-07-02 at 10 23 47" src="https://user-images.githubusercontent.com/115237/60496695-a3a3a280-9cb3-11e9-8606-9af203a64d30.png">

GiteaMirror added the issue/confirmed type/enhancement labels 2025-11-02 05:16:03 -06:00

GiteaMirror closed this issue

2025-11-02 05:16:04 -06:00

GiteaMirror commented

2025-11-02 05:16:04 -06:00

@br-aw commented on GitHub (Jul 2, 2019):

When someone makes a large change, we need to be able to see it.

@br-aw commented on GitHub (Jul 2, 2019): When someone makes a large change, we need to be able to see it.

GiteaMirror commented

2025-11-02 05:16:04 -06:00

@stale[bot] commented on GitHub (Aug 31, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Aug 31, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:16:05 -06:00

@guillep2k commented on GitHub (Oct 25, 2019):

To avoid cluttering the diff view for the PR/commit/etc., this could be implemented with a page of its own; the commit diff page can provide a link in these cases so the user can open it in a new tab.

@guillep2k commented on GitHub (Oct 25, 2019): To avoid cluttering the diff view for the PR/commit/etc., this could be implemented with a page of its own; the commit diff page can provide a link in these cases so the user can open it in a new tab.

GiteaMirror commented

2025-11-02 05:16:05 -06:00

@brandonkal commented on GitHub (Oct 25, 2019):

@guillep2k is on to something here. Being able to diff between arbitrary commits would be great.

One of the great features of gitea is the commit graph. A larger font and more whitespace should be used there to refine the UI.

@brandonkal commented on GitHub (Oct 25, 2019): @guillep2k is on to something here. Being able to diff between arbitrary commits would be great. One of the great features of gitea is the commit graph. A larger font and more whitespace should be used there to refine the UI.

GiteaMirror commented

2025-11-02 05:16:05 -06:00

@zeripath commented on GitHub (Oct 26, 2019):

Tbh the whole diff generating structure needs review.

Huge diffs that don't change lots of files are not truncated and in fact are read completely into memory affecting both the server and the client's ability to function.

With any sensible rearchitecture we'll be able to grab extra diffs but it's getting the time to do this.

(This is what I mean when I say the compare endpoint needs to be completely reviewed - there are serious flaws at every point.)

@zeripath commented on GitHub (Oct 26, 2019): Tbh the whole diff generating structure needs review. Huge diffs that don't change lots of files are not truncated and in fact are read completely into memory affecting both the server and the client's ability to function. With any sensible rearchitecture we'll be able to grab extra diffs but it's getting the time to do this. (This is what I mean when I say the compare endpoint needs to be completely reviewed - there are serious flaws at every point.)

GiteaMirror commented

2025-11-02 05:16:05 -06:00

@iarepandemonium commented on GitHub (Feb 20, 2021):

Chiming in that I need this, since it's causing problems in that I can't put comments on specific lines in PRs.

@iarepandemonium commented on GitHub (Feb 20, 2021): Chiming in that I need this, since it's causing problems in that I can't put comments on specific lines in PRs.

GiteaMirror commented

2025-11-02 05:16:06 -06:00

@lorenzocasasanta commented on GitHub (Aug 11, 2021):

Has there been any development on this?

@lorenzocasasanta commented on GitHub (Aug 11, 2021): Has there been any development on this?

GiteaMirror commented

2025-11-02 05:16:06 -06:00

@zeripath commented on GitHub (Aug 11, 2021):

I am currently looking (again) at this - part of the problem is that our code for generating compare pages is rather complex and altogether too interrelated.

This PR fixing this will be big and require lots of time.

@zeripath commented on GitHub (Aug 11, 2021): I am currently looking (again) at this - part of the problem is that our code for generating compare pages is rather complex and altogether too interrelated. This PR fixing this will be big and require lots of time.

GiteaMirror commented

2025-11-02 05:16:06 -06:00

@silverwind commented on GitHub (Aug 12, 2021):

I think we should aim to have the same mechanism to generate diffs and code view outputs. There currently seem to be two mechanisms at work which also product differences in syntax highlighting and such, for example https://github.com/go-gitea/gitea/issues/16434#issuecomment-880672411.

@silverwind commented on GitHub (Aug 12, 2021): I think we should aim to have the same mechanism to generate diffs and code view outputs. There currently seem to be two mechanisms at work which also product differences in syntax highlighting and such, for example https://github.com/go-gitea/gitea/issues/16434#issuecomment-880672411.

GiteaMirror commented

2025-11-02 05:16:06 -06:00

@delvh commented on GitHub (Apr 29, 2023):

Has been implemented by now:

@delvh commented on GitHub (Apr 29, 2023): Has been implemented by now: ![image](https://user-images.githubusercontent.com/51889757/235326499-0d8067bd-bc8f-4f89-8580-77a8d7a502f2.png)

GiteaMirror referenced this issue

2025-11-02 12:23:27 -06:00

[PR #3532] [MERGED] Document generate commands #16978

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#3532