Webhook for slack sent wrong username #3496

Closed
opened 2025-11-02 05:14:52 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @stani0502 on GitHub (Jun 20, 2019).

  • Gitea version (or commit ref):
  • Git version: 1.8.3
  • Operating system: ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Issue on webhook for slack, when tried to modify release tag (edit or deleting), the notification always show the creator name.
For example :

  1. User A creating tag v1.0.0
    Slack Notification: [RepoName] new release v1.0.0 published by User A
  2. User B updating content for tag v1.0.0
    Select Notification: [RepoName] new release v1.0.0 updated by User A
  3. User B delete tag v1.0.0
    Select Notification: [RepoName] new release v1.0.0 deleted by User A
    ...

Screenshots

Originally created by @stani0502 on GitHub (Jun 20, 2019). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): - Git version: 1.8.3 - Operating system: ubuntu - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [X] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [X] Not relevant - Log gist: ## Description Issue on webhook for slack, when tried to modify release tag (edit or deleting), the notification always show the creator name. For example : 1. User A creating tag v1.0.0 Slack Notification: `[RepoName] new release v1.0.0 published by User A` 2. User B updating content for tag v1.0.0 Select Notification: `[RepoName] new release v1.0.0 updated by User A` 3. User B delete tag v1.0.0 Select Notification: `[RepoName] new release v1.0.0 deleted by User A` ... ## Screenshots <!-- **If this issue involves the Web Interface, please include a screenshot** -->
GiteaMirror added the type/bug label 2025-11-02 05:14:52 -06:00
Author
Owner

@stale[bot] commented on GitHub (Aug 19, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Aug 19, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
Author
Owner

@sapk commented on GitHub (Aug 19, 2019):

I think it come from 85202d4784/models/release.go (L467) and 85202d4784/models/release.go (L412) where it should be doer and not rel.Publisher

This could be tagged as a good first issue.

@sapk commented on GitHub (Aug 19, 2019): I think it come from https://github.com/go-gitea/gitea/blob/85202d4784758573f80f93dbbda97a444e7ece99/models/release.go#L467 and https://github.com/go-gitea/gitea/blob/85202d4784758573f80f93dbbda97a444e7ece99/models/release.go#L412 where it should be `doer` and not `rel.Publisher` This could be tagged as a good first issue.
Author
Owner

@lafriks commented on GitHub (Aug 19, 2019):

wasn't this already fixed in 1.9.x?

@lafriks commented on GitHub (Aug 19, 2019): wasn't this already fixed in 1.9.x?
Author
Owner

@lunny commented on GitHub (Aug 20, 2019):

#7774 should already fix a slack problem but not this one.

@lunny commented on GitHub (Aug 20, 2019): #7774 should already fix a slack problem but not this one.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3496