gitea can not show pdf annotation #3432

@stale[bot] commented on GitHub (Aug 12, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Aug 12, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

@sapk commented on GitHub (Aug 13, 2019):

@laoshaw We updated the pdf viewer lib. Can you test on try.gitea.io if it works now ?

@sapk commented on GitHub (Aug 13, 2019): @laoshaw We updated the pdf viewer lib. Can you test on try.gitea.io if it works now ?

GiteaMirror commented

@laoshaw commented on GitHub (Aug 13, 2019):

Just did a quick test unfortunately it basically still is not working, only a pop-up notes shown, all the highlight underline etc are no-shows.

@laoshaw commented on GitHub (Aug 13, 2019): Just did a quick test unfortunately it basically still is not working, only a pop-up notes shown, all the highlight underline etc are no-shows.

GiteaMirror commented

@laoshaw commented on GitHub (Aug 13, 2019):

https://pdf-highlighter.com/docs/Highlighting_PDF_Viewer.html this is based on pdf.js and it seems had things integrated well too

@laoshaw commented on GitHub (Aug 13, 2019): https://pdf-highlighter.com/docs/Highlighting_PDF_Viewer.html this is based on pdf.js and it seems had things integrated well too

GiteaMirror commented

@lunny commented on GitHub (Aug 14, 2019):

closed by #7834

@lunny commented on GitHub (Aug 14, 2019): closed by #7834

GiteaMirror commented

@laoshaw commented on GitHub (Aug 14, 2019):

why close this so quickly?

@laoshaw commented on GitHub (Aug 14, 2019): why close this so quickly?

GiteaMirror commented

@sapk commented on GitHub (Aug 14, 2019):

We shouldn't have close it if not fixed.
I don't know a lot concerning pdf possibility but Highlighting PDF Viewer seems to need a serve side part.

Our viewer extension receives highlighting meta-data from the server and marks keywords in PDF viewer

Have you try to open your pdf with it ?

@sapk commented on GitHub (Aug 14, 2019): We shouldn't have close it if not fixed. I don't know a lot concerning pdf possibility but Highlighting PDF Viewer seems to need a serve side part. > Our viewer extension receives highlighting meta-data from the server and marks keywords in PDF viewer Have you try to open your pdf with it ?

GiteaMirror commented

@laoshaw commented on GitHub (Aug 14, 2019):

new pdf.js supposedly should be able to open annotation somehow it did not work under gitea yet. i have not used highlight-pdf-viewer myself. I will try to debug when I become more familiar with golang.

@laoshaw commented on GitHub (Aug 14, 2019): new pdf.js supposedly should be able to open annotation somehow it did not work under gitea yet. i have not used highlight-pdf-viewer myself. I will try to debug when I become more familiar with golang.

GiteaMirror commented

@laoshaw commented on GitHub (Aug 14, 2019):

https://usefulangle.com/post/94/javascript-pdfjs-enable-annotation-layer How to Enable Annotations in PDF.JS

@laoshaw commented on GitHub (Aug 14, 2019): https://usefulangle.com/post/94/javascript-pdfjs-enable-annotation-layer How to Enable Annotations in PDF.JS

GiteaMirror commented

@sapk commented on GitHub (Aug 14, 2019):

If you want to give it a try, pdfjs is now on the latest version and we load the viewer of pdfjs here : bcbc9f33d7/templates/repo/view_file.tmpl (L66)
The viewer is located here : https://github.com/go-gitea/gitea/tree/master/public/vendor/plugins/pdfjs

I don't think you will need to learn Go (just need to install it) to fix this as it is more a frontend problem.
The command : TAGS=sqlite make clean generate build && ./gitea should be enough to start locally gitea with your changes.

Don't hesitate to open a PR to discuss over your code.

@sapk commented on GitHub (Aug 14, 2019): If you want to give it a try, pdfjs is now on the latest version and we load the viewer of pdfjs here : https://github.com/go-gitea/gitea/blob/bcbc9f33d73393c47b27793ac91b8f9faf98d349/templates/repo/view_file.tmpl#L66 The viewer is located here : https://github.com/go-gitea/gitea/tree/master/public/vendor/plugins/pdfjs I don't think you will need to learn Go (just need to install it) to fix this as it is more a frontend problem. The command : `TAGS=sqlite make clean generate build && ./gitea` should be enough to start locally gitea with your changes. Don't hesitate to open a PR to discuss over your code.

GiteaMirror commented

@yp05327 commented on GitHub (Sep 19, 2024):

Any samples for test? Maybe this has been fixed.

@yp05327 commented on GitHub (Sep 19, 2024): Any samples for test? Maybe this has been fixed.

GiteaMirror commented

@wxiaoguang commented on GitHub (Sep 19, 2024):

There is no pdfjs anymore. PDF is rendered natively if it could be.

@wxiaoguang commented on GitHub (Sep 19, 2024): There is no pdfjs anymore. PDF is rendered natively if it could be.

GiteaMirror commented