github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Disabling IMPORT_LOCAL_PATHS does not work #342

New Issue
Closed
opened 2025-11-02 03:19:18 -06:00 by GiteaMirror · 14 comments
GiteaMirror commented 2025-11-02 03:19:18 -06:00
Owner
Copy Link

Originally created by @rugk on GitHub (Feb 10, 2017).

see
https://github.com/gogits/gogs/issues/4033#issuecomment-275539518
ae319da5fd

ref https://github.com/go-gitea/gitea/issues/715

Is this option already integrated or does Gitea behave in a similar way (just without an option to change the behaviour?)?

Originally created by @rugk on GitHub (Feb 10, 2017). see https://github.com/gogits/gogs/issues/4033#issuecomment-275539518 https://github.com/gogits/gogs/commit/ae319da5fd91c102b387296f9884401e120f9b79 ref https://github.com/go-gitea/gitea/issues/715 --- Is this option already integrated or does Gitea behave in a similar way (just without an option to change the behaviour?)?
GiteaMirror added the issue/not-a-bug label 2025-11-02 03:19:18 -06:00
GiteaMirror commented 2025-11-02 03:19:18 -06:00
Author
Owner
Copy Link

@rugk commented on GitHub (Feb 10, 2017):

As far as I see in 1.0.1 the local server path import is still possible at least for admins. As said, I also want to disable that.

@rugk commented on GitHub (Feb 10, 2017): As far as I see in 1.0.1 the local server path import is still possible at least for admins. As said, I also want to disable that.
GiteaMirror commented 2025-11-02 03:19:19 -06:00
Author
Owner
Copy Link

@minecrafter commented on GitHub (Feb 11, 2017):

In Gitea, the option is called IMPORT_LOCAL_PATHS: https://github.com/go-gitea/gitea/blob/master/conf/app.ini#L181

@minecrafter commented on GitHub (Feb 11, 2017): In Gitea, the option is called `IMPORT_LOCAL_PATHS`: https://github.com/go-gitea/gitea/blob/master/conf/app.ini#L181
GiteaMirror commented 2025-11-02 03:19:19 -06:00
Author
Owner
Copy Link

@rugk commented on GitHub (Feb 11, 2017):

Even after setting it to false in the UI is is sill shown "or a local server path". (German version)

@rugk commented on GitHub (Feb 11, 2017): Even after setting it to false in the UI is is sill shown "or a local server path". (German version)
GiteaMirror commented 2025-11-02 03:19:19 -06:00
Author
Owner
Copy Link

@minecrafter commented on GitHub (Feb 11, 2017):

The UI still shows but the app.ini setting does work, even trumping the user's permission.

@minecrafter commented on GitHub (Feb 11, 2017): The UI still shows but the `app.ini` setting does work, even trumping the user's permission.
GiteaMirror commented 2025-11-02 03:19:19 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Feb 11, 2017):

So this is not an issue?

@lunny commented on GitHub (Feb 11, 2017): So this is not an issue?
GiteaMirror commented 2025-11-02 03:19:19 -06:00
Author
Owner
Copy Link

@rugk commented on GitHub (Feb 11, 2017):

A wrong UI is IMHO an issue.

@rugk commented on GitHub (Feb 11, 2017): A wrong UI is IMHO an issue.
GiteaMirror commented 2025-11-02 03:19:20 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Feb 11, 2017):

Which UI? Could you change this issue's title and put some screenshot here? Or maybe you can fire another issue and close this one?

@lunny commented on GitHub (Feb 11, 2017): Which UI? Could you change this issue's title and put some screenshot here? Or maybe you can fire another issue and close this one?
GiteaMirror commented 2025-11-02 03:19:20 -06:00
Author
Owner
Copy Link

@rugk commented on GitHub (Feb 11, 2017):

See @minecrafter replies…

@rugk commented on GitHub (Feb 11, 2017): See @minecrafter replies…
GiteaMirror commented 2025-11-02 03:19:20 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Feb 14, 2017):

I cannot reproduce it on current master 7eb8daf, please see 7eb8daffa3/templates/repo/migrate.tmpl (L15) and 7eb8daffa3/models/user.go (L235) . Please feel free to reopen it.

@lunny commented on GitHub (Feb 14, 2017): I cannot reproduce it on current master 7eb8daf, please see https://github.com/go-gitea/gitea/blob/7eb8daffa3181f6bae7aac95d536c68c6bed0e33/templates/repo/migrate.tmpl#L15 and https://github.com/go-gitea/gitea/blob/7eb8daffa3181f6bae7aac95d536c68c6bed0e33/models/user.go#L235 . Please feel free to reopen it.
GiteaMirror commented 2025-11-02 03:19:20 -06:00
Author
Owner
Copy Link

@rugk commented on GitHub (Feb 14, 2017):

Ah indeed it is no UI issue, the option does not work in any way. In the config I've set IMPORT_LOCAL_PATHS = false under [security] but as a non-admin user I can still import local repos!

So please reopen. Users cannot do so on GitHub if repo admins close an issue.

Gitea v1.0.1

@rugk commented on GitHub (Feb 14, 2017): Ah indeed it is no UI issue, the option does not work in any way. In the config I've set `IMPORT_LOCAL_PATHS = false` under `[security]` but as a non-admin user I can still import local repos! So please reopen. Users cannot do so on GitHub if repo admins close an issue. Gitea v1.0.1
GiteaMirror commented 2025-11-02 03:19:20 -06:00
Author
Owner
Copy Link

@Bwko commented on GitHub (Feb 14, 2017):

@rugk This feature is added to the latest master not to Gitea v1.0.1

@Bwko commented on GitHub (Feb 14, 2017): @rugk This feature is added to the latest master not to Gitea v1.0.1
GiteaMirror commented 2025-11-02 03:19:21 -06:00
Author
Owner
Copy Link

@rugk commented on GitHub (Feb 14, 2017):

Ah, that's the issue, I see…

@rugk commented on GitHub (Feb 14, 2017): Ah, that's the issue, I see…
GiteaMirror commented 2025-11-02 03:19:21 -06:00
Author
Owner
Copy Link

@tboerger commented on GitHub (Feb 14, 2017):

Marked as invalid as it correctly works on master.

@tboerger commented on GitHub (Feb 14, 2017): Marked as invalid as it correctly works on master.
GiteaMirror commented 2025-11-02 03:19:21 -06:00
Author
Owner
Copy Link

@rugk commented on GitHub (Jun 24, 2017):

I can confirm it is fixed, however changing the UI would still be nice. It is not useful to first offer the user to "import local repos" and then say, they do not have the privileges to do so, when they actually (try to) do it.

@rugk commented on GitHub (Jun 24, 2017): I can confirm it is fixed, however changing the UI would still be nice. It is not useful to first offer the user to "import local repos" and then say, they do not have the privileges to do so, when they actually (try to) do it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/not-a-bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#342
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?