github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Unnecessary pull request restriction #3413

New Issue
Closed
opened 2025-11-02 05:12:11 -06:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-02 05:12:11 -06:00
Owner
Copy Link

Originally created by @PlanetRenox-zz on GitHub (Jun 2, 2019).

  • Gitea version: 1.8.2
  • Operating system: CentOs 7
  • Database:
    • SQLite
  • Can you reproduce the bug?
    • Yes

Description

Unable to approve own pull request if you are the only whitelisted user capable of approving requests.

This restriction seems unnecessary.

Originally created by @PlanetRenox-zz on GitHub (Jun 2, 2019). - Gitea version: 1.8.2 - Operating system: CentOs 7 - Database: - [x] SQLite - Can you reproduce the bug? - [x] Yes ## Description Unable to approve own pull request if you are the only whitelisted user capable of approving requests. This restriction seems unnecessary.
GiteaMirror added the proposal/rejected label 2025-11-02 05:12:11 -06:00
GiteaMirror commented 2025-11-02 05:12:12 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 26, 2022):

If you are the only approver, why not just merge it?

From another point of view, "approve own pull request" seems also unnecessary .... GitHub also do not allow self-approve IIRC.

@wxiaoguang commented on GitHub (Oct 26, 2022): If you are the only approver, why not just merge it? From another point of view, "approve own pull request" seems also unnecessary .... GitHub also do not allow self-approve IIRC.
GiteaMirror commented 2025-11-02 05:12:12 -06:00
Author
Owner
Copy Link

@delvh commented on GitHub (Oct 26, 2022):

We allow approving your own PR at all?
No, just tested it, that's not possible, and I would like to keep it this way…

@delvh commented on GitHub (Oct 26, 2022): We allow approving your own PR at all? No, just tested it, that's not possible, and I would like to keep it this way…
GiteaMirror commented 2025-11-02 05:12:12 -06:00
Author
Owner
Copy Link

@eeyrjmr commented on GitHub (Oct 26, 2022):

There is a way and it is if you are the admin of the repository.

I opened a feature request to disable this since code review is beneficial (the repo admin can turn it off if they need to force something through).

@eeyrjmr commented on GitHub (Oct 26, 2022): There is a way and it is if you are the admin of the repository. I opened a feature request to disable this since code review is beneficial (the repo admin can turn it off if they need to force something through).
GiteaMirror commented 2025-11-02 05:12:12 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 26, 2022):

There is a way and it is if you are the admin of the repository.

If they are the only user, why not just consider "Merge it" as approved and "Close it" as rejected? Why someone needs to approve their own PRs?

@wxiaoguang commented on GitHub (Oct 26, 2022): > There is a way and it is if you are the admin of the repository. If they are the only user, why not just consider "Merge it" as approved and "Close it" as rejected? Why someone needs to approve their own PRs?
GiteaMirror commented 2025-11-02 05:12:13 -06:00
Author
Owner
Copy Link

@eeyrjmr commented on GitHub (Oct 26, 2022):

There is a way and it is if you are the admin of the repository.

If they are the only user, why not just consider "Merge it" as approved and "Close it" as rejected? Why someone needs to approve their own PRs?

Why enable branch protection if you are the only user.

@eeyrjmr commented on GitHub (Oct 26, 2022): > > There is a way and it is if you are the admin of the repository. > > If they are the only user, why not just consider "Merge it" as approved and "Close it" as rejected? Why someone needs to approve their own PRs? Why enable branch protection if you are the only user.
GiteaMirror commented 2025-11-02 05:12:13 -06:00
Author
Owner
Copy Link

@wxiaoguang commented on GitHub (Oct 26, 2022):

IIRC even if the branch protection is enabled, the only user still can merge by the UI.

@wxiaoguang commented on GitHub (Oct 26, 2022): IIRC even if the branch protection is enabled, the only user still can merge by the UI.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label proposal/rejected
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?