Check tracker url syntax #3389

New Issue

GiteaMirror · 2025-11-02T05:11:22-06:00

GiteaMirror commented

2025-11-02 05:11:22 -06:00

Originally created by @Grelog on GitHub (May 28, 2019).

Gitea version (or commit ref): 81adf6a
Git version:
Operating system:
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Description

Some time ago we created a new repository and added a connection to our external issue tracking system Tuleap.
We used this repository a while and didn´t recognized that there was a problem with the tracking url.

Yesterday i pushed a commit containing a tracker id in the commit message for the first time. After this, it wasn´t possible to view the repository in the web view anymore.
Because of this i wasn´t able to review or reconfigure the repository settings. I could only delete the whole repository via admin settings.

Web output in repository view:
template: repo/view_list:30:35: executing "repo/view_list" at <RenderCommitMessage .LatestCommit.Summary .RepoLink $.Repository.ComposeMetas>: error calling RenderCommitMessage: runtime error: slice bounds out of range
and in diff view:
template: repo/diff/page:12:28: executing "repo/diff/page" at <RenderCommitMessage .Commit.Message $.RepoLink $.Repository.ComposeMetas>: error calling RenderCommitMessage: runtime error: slice bounds out of range

In the gitea db i found a table called repo_unit with configuration data of the repos.
In this case the entry was
{"ExternalTrackerURL":"https://sampledomain.com/plugins/tracker/?tracker=161","ExternalTrackerFormat":"https://sampledomain.com/plugins/tracker/?aid={index]","ExternalTrackerStyle":"numeric"}
My colleague did a mistake on closing brackets > ?aid={index]

I suggest the web interface should perform an error check on entering the external tracker url to prevent such problems.

On try.gitea.io the problem seems to only occur on diff view and graph so this problem can be fixed in the web interface if you know what the problem is.
see here 643c2b2651
and here https://try.gitea.io/Grelog/test1/graph

Originally created by @Grelog on GitHub (May 28, 2019). - Gitea version (or commit ref): 81adf6a - Git version: - Operating system: - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (provide example URL) - [ ] No - [ ] Not relevant - Log gist: ## Description Some time ago we created a new repository and added a connection to our external issue tracking system Tuleap. We used this repository a while and didn´t recognized that there was a problem with the tracking url. Yesterday i pushed a commit containing a tracker id in the commit message for the first time. After this, it wasn´t possible to view the repository in the web view anymore. Because of this i wasn´t able to review or reconfigure the repository settings. I could only delete the whole repository via admin settings. Web output in repository view: `template: repo/view_list:30:35: executing "repo/view_list" at <RenderCommitMessage .LatestCommit.Summary .RepoLink $.Repository.ComposeMetas>: error calling RenderCommitMessage: runtime error: slice bounds out of range` and in diff view: `template: repo/diff/page:12:28: executing "repo/diff/page" at <RenderCommitMessage .Commit.Message $.RepoLink $.Repository.ComposeMetas>: error calling RenderCommitMessage: runtime error: slice bounds out of range` In the gitea db i found a table called repo_unit with configuration data of the repos. In this case the entry was `{"ExternalTrackerURL":"https://sampledomain.com/plugins/tracker/?tracker=161","ExternalTrackerFormat":"https://sampledomain.com/plugins/tracker/?aid={index]","ExternalTrackerStyle":"numeric"}` My colleague did a mistake on closing brackets > `?aid={index]` I suggest the web interface should perform an error check on entering the external tracker url to prevent such problems. On try.gitea.io the problem seems to only occur on diff view and graph so this problem can be fixed in the web interface if you know what the problem is. see here https://try.gitea.io/Grelog/test1/commit/643c2b265183847ace82967542ce40ac2ce92a7f and here https://try.gitea.io/Grelog/test1/graph

GiteaMirror closed this issue

2025-11-02 05:11:22 -06:00

GiteaMirror referenced this issue

2025-11-02 12:32:54 -06:00

[PR #4331] [MERGED] Switch plaintext scratch tokens to use hash instead #17336

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#3389