Git Hooks not editable and not working #3370

@ghost commented on GitHub (May 25, 2019):

Might be that your user does not have edit hooks rights or you have hooks editing disabled in app.ini

I added specifically DISABLE_GIT_HOOKS = false in the app.ini located in

/var/lib/docker/volumes/gitea_main_data/_data/gitea/conf# nano app.ini

I restarted the service but that wasn't the issue.

I am using an organisation which owns the repository and my user is member of that organisation. My user is administrator, too. So I should have the privileagues. Do you have any other ideas?

@ghost commented on GitHub (May 25, 2019): > Might be that your user does not have edit hooks rights or you have hooks editing disabled in app.ini I added specifically DISABLE_GIT_HOOKS = false in the app.ini located in `/var/lib/docker/volumes/gitea_main_data/_data/gitea/conf# nano app.ini` I restarted the service but that wasn't the issue. I am using an organisation which owns the repository and my user is member of that organisation. My user is administrator, too. So I should have the privileagues. Do you have any other ideas?

GiteaMirror commented

@zeripath commented on GitHub (May 25, 2019):

How are you pushing?

@zeripath commented on GitHub (May 25, 2019): How are you pushing?

GiteaMirror commented

@ghost commented on GitHub (May 25, 2019):

How are you pushing?

I push with HTTPS and not SSH.

@ghost commented on GitHub (May 25, 2019): > How are you pushing? I push with HTTPS and not SSH.

GiteaMirror commented

@zeripath commented on GitHub (May 25, 2019):

Are you sure that you have the repositories directory mounted executable?

@zeripath commented on GitHub (May 25, 2019): Are you sure that you have the repositories directory mounted executable?

GiteaMirror commented

@ghost commented on GitHub (May 25, 2019):

bash-4.4# pwd
/data/git/repositories/wordpress/ziin_hp_wp.git
bash-4.4# ls -lah
total 248
drwxr-xr-x    8 git      git         4.0K May 23 21:17 .
drwxr-xr-x    4 git      git         4.0K Apr 24 21:38 ..
-rw-r--r--    1 root     root          23 May 23 18:01 HEAD
-rw-r--r--    1 root     root          41 May 23 18:02 ORIG_HEAD
drwxr-xr-x    2 git      git         4.0K Feb 18 18:01 branches
-rw-r--r--    1 git      git           66 Feb 18 18:01 config
-rw-r--r--    1 git      git           73 Feb 18 18:01 description
drwxr-xr-x    5 git      git         4.0K May 23 23:10 hooks
-rw-r--r--    1 root     root      198.9K May 23 18:02 index
drwxr-xr-x    2 git      git         4.0K May 13 09:03 info
drwxr-xr-x    2 git      git         4.0K Apr 23 15:20 logs
drwxr-xr-x  147 git      git         4.0K May 23 21:17 objects
drwxr-xr-x    4 git      git         4.0K Feb 18 18:01 refs
bash-4.4#

@ghost commented on GitHub (May 25, 2019): ``` bash-4.4# pwd /data/git/repositories/wordpress/ziin_hp_wp.git bash-4.4# ls -lah total 248 drwxr-xr-x 8 git git 4.0K May 23 21:17 . drwxr-xr-x 4 git git 4.0K Apr 24 21:38 .. -rw-r--r-- 1 root root 23 May 23 18:01 HEAD -rw-r--r-- 1 root root 41 May 23 18:02 ORIG_HEAD drwxr-xr-x 2 git git 4.0K Feb 18 18:01 branches -rw-r--r-- 1 git git 66 Feb 18 18:01 config -rw-r--r-- 1 git git 73 Feb 18 18:01 description drwxr-xr-x 5 git git 4.0K May 23 23:10 hooks -rw-r--r-- 1 root root 198.9K May 23 18:02 index drwxr-xr-x 2 git git 4.0K May 13 09:03 info drwxr-xr-x 2 git git 4.0K Apr 23 15:20 logs drwxr-xr-x 147 git git 4.0K May 23 21:17 objects drwxr-xr-x 4 git git 4.0K Feb 18 18:01 refs bash-4.4# ```

GiteaMirror commented

@zeripath commented on GitHub (May 25, 2019):

I mean the mount, not the directory.

@zeripath commented on GitHub (May 25, 2019): I mean the mount, not the directory.

GiteaMirror commented

@ghost commented on GitHub (May 25, 2019):

I use Docker volumes. My docker-compose.yml uses the following statements to mount the volume:

Withhin the service:

volumes:
      - 'main_data:/data'

And the Volumes defintion:

volumes:
  mysql_data:
    driver: local
  main_data:
    driver: local

How do I make it executable?

I tried to execute the post-receive hook from the container and it worked, though.

@ghost commented on GitHub (May 25, 2019): I use Docker volumes. My docker-compose.yml uses the following statements to mount the volume: Withhin the service: ``` volumes: - 'main_data:/data' ``` And the Volumes defintion: ``` volumes: mysql_data: driver: local main_data: driver: local ``` How do I make it executable? I tried to execute the post-receive hook from the container and it worked, though.

GiteaMirror commented

@zeripath commented on GitHub (May 25, 2019):

just check mount from within the gitea container - but the fact that you say you can execute the hooks makes this less suspect.

What is more concerning is that the index, HEAD and ORIG_HEAD being owned by root in that repository.

Being unable to update HEAD could easily be cause for things failing. I'm fairly certain that everything in those repositories should be owned by git.

@zeripath commented on GitHub (May 25, 2019): just check mount from within the gitea container - but the fact that you say you can execute the hooks makes this less suspect. What is more concerning is that the index, HEAD and ORIG_HEAD being owned by root in that repository. Being unable to update HEAD could easily be cause for things failing. I'm fairly certain that everything in those repositories should be owned by git.

GiteaMirror commented

@ghost commented on GitHub (May 25, 2019):

Here is what my mount settings looks from the container:

Mounts
0
Destination /data
Driver local
Mode z
Name gitea_main_data
Propagation
RW true
Source /var/lib/docker/volumes/gitea_main_data/_data
Type volume

I rechecked that I can execute scripts from within the container. I logged in the container, switched from user root to git, created an executable shell script, added some stuff and executed it. Worked like a charm.

I changed recursively the owner to git:git for all files.

I pushed and it's the same issue :-(

@ghost commented on GitHub (May 25, 2019): Here is what my mount settings looks from the container: ``` Mounts 0 Destination /data Driver local Mode z Name gitea_main_data Propagation RW true Source /var/lib/docker/volumes/gitea_main_data/_data Type volume ``` I rechecked that I can execute scripts from within the container. I logged in the container, switched from user root to git, created an executable shell script, added some stuff and executed it. Worked like a charm. I changed recursively the owner to git:git for all files. I pushed and it's the same issue :-(

GiteaMirror commented

@ghost commented on GitHub (May 25, 2019):

Just to be on the safe side:

I added my post-receive hook under

/var/lib/docker/volumes/gitea_main_data/_data/git/repositories/wordpress/ziin_hp_wp.git/hooks/post-receive.d

The file is also called post-receive.

drwxr-xr-x 2 git git 4.0K May 25 19:55 .
drwxr-xr-x 5 git git 4.0K May 24 01:10 ..
-rwxr-xr-x 1 git git   93 Feb 18 19:01 gitea
-rwxr-xr-x 1 git git  967 May 23 20:06 post-receive
root:/var/lib/docker/volumes/gitea_main_data/_data/git/repositories/wordpress/ziin_hp_wp.git/hooks/post-receive.d#

@ghost commented on GitHub (May 25, 2019): Just to be on the safe side: I added my post-receive hook under `/var/lib/docker/volumes/gitea_main_data/_data/git/repositories/wordpress/ziin_hp_wp.git/hooks/post-receive.d` The file is also called `post-receive`. ``` drwxr-xr-x 2 git git 4.0K May 25 19:55 . drwxr-xr-x 5 git git 4.0K May 24 01:10 .. -rwxr-xr-x 1 git git 93 Feb 18 19:01 gitea -rwxr-xr-x 1 git git 967 May 23 20:06 post-receive root:/var/lib/docker/volumes/gitea_main_data/_data/git/repositories/wordpress/ziin_hp_wp.git/hooks/post-receive.d# ```

GiteaMirror commented

@zeripath commented on GitHub (May 25, 2019):

You need to check these things from within the docker itself. It doesn't matter what you can do outside of the docker.

docker exec -it gitea_docker_name "bash"

And then check these things.

@zeripath commented on GitHub (May 25, 2019): You need to check these things from within the docker itself. It doesn't matter what you can do outside of the docker. ``` docker exec -it gitea_docker_name "bash" ``` And then check these things.

GiteaMirror commented

@ghost commented on GitHub (May 26, 2019):

First, I have reset my Docker environment. At least, the edit buttons are now back. It must be something from an older update, I don't know. At least, I see the edit buttons and have now entered the hook over the GUI. Still, it is not executed.

@ghost commented on GitHub (May 26, 2019): First, I have reset my Docker environment. At least, the edit buttons are now back. It must be something from an older update, I don't know. At least, I see the edit buttons and have now entered the hook over the GUI. Still, it is not executed.

GiteaMirror commented

@ghost commented on GitHub (May 26, 2019):

You need to check these things from within the docker itself. It doesn't matter what you can do outside of the docker.
docker exec -it gitea_docker_name "bash"
And then check these things.

bash-4.4# ls -l
total 8
-rwxrwx---    1 git      git             93 May 26 11:39 gitea
-rwxrwx---    1 git      git            965 May 26 11:53 post-receive
bash-4.4# ./post-receive
bash-4.4# pwd
/data/git/repositories/wordpress/ziin_hp_wp.git/hooks/post-receive.d
bash-4.4#

I can successfully execute the hook manually.

@ghost commented on GitHub (May 26, 2019): > You need to check these things from within the docker itself. It doesn't matter what you can do outside of the docker. > > ``` > docker exec -it gitea_docker_name "bash" > ``` > > And then check these things. ``` bash-4.4# ls -l total 8 -rwxrwx--- 1 git git 93 May 26 11:39 gitea -rwxrwx--- 1 git git 965 May 26 11:53 post-receive bash-4.4# ./post-receive bash-4.4# pwd /data/git/repositories/wordpress/ziin_hp_wp.git/hooks/post-receive.d bash-4.4# ``` I can successfully execute the hook manually.

GiteaMirror commented