Make go1.11 the minimal version #3169

New Issue

GiteaMirror · 2025-11-02T05:02:37-06:00

GiteaMirror commented

2025-11-02 05:02:37 -06:00

Originally created by @coolaj86 on GitHub (Apr 10, 2019).

If we're willing to make go1.11 the minimal version I can make the build system much simpler and reduce the some of the build task times on drone by a factor of 10 (to the extent that much of the time is spent re-downloading dependencies).

Also, Windows support gets simpler.

The one thing that requires education is that people need to know that gitea CANNOT live in GOPATH when using go.mod.

In go1.13 the default behavior will change. I'm not sure if GOPATH will just be ignored or what they plan to do.

Originally created by @coolaj86 on GitHub (Apr 10, 2019). If we're willing to make go1.11 the minimal version I can make the build system much simpler and reduce the some of the build task times on drone by a factor of 10 (to the extent that much of the time is spent re-downloading dependencies). Also, Windows support gets simpler. The one thing that requires education is that people need to know that gitea CANNOT live in GOPATH when using `go.mod`. In go1.13 the default behavior will change. I'm not sure if GOPATH will just be ignored or what they plan to do.

GiteaMirror added the type/proposal label 2025-11-02 05:02:37 -06:00

GiteaMirror closed this issue

2025-11-02 05:02:37 -06:00

GiteaMirror commented

2025-11-02 05:02:38 -06:00

@sapk commented on GitHub (Apr 10, 2019):

The main blocking problem is go-swagger currently not working outside GOPATH.

@sapk commented on GitHub (Apr 10, 2019): The main blocking problem is go-swagger currently not working outside GOPATH.

GiteaMirror commented

2025-11-02 05:02:38 -06:00

@coolaj86 commented on GitHub (Apr 10, 2019):

@sapk Would it be okay to document that the minimum required version is go1.11 and iteratively make changes that don't break swagger (or errcheck)?

@coolaj86 commented on GitHub (Apr 10, 2019): @sapk Would it be okay to document that the minimum required version is go1.11 and iteratively make changes that don't break swagger (or errcheck)?

GiteaMirror commented

2025-11-02 05:02:38 -06:00

@sapk commented on GitHub (Apr 10, 2019):

Personally, I am following golang recommendation of supporting the last two versions so no problem with that. But some os are not up to date on that and some user can be impacted by such choice. In fact, we are more in at minimum supporting the three last release without gcc (https://github.com/go-gitea/gitea/blob/master/.drone.yml#L59).

@sapk commented on GitHub (Apr 10, 2019): Personally, I am following golang recommendation of supporting the last two versions so no problem with that. But some os are not up to date on that and some user can be impacted by such choice. In fact, we are more in at minimum supporting the three last release without gcc (https://github.com/go-gitea/gitea/blob/master/.drone.yml#L59).

GiteaMirror commented

2025-11-02 05:02:38 -06:00

@lunny commented on GitHub (Aug 15, 2019):

I think this has been resolved.

@lunny commented on GitHub (Aug 15, 2019): I think this has been resolved.

GiteaMirror referenced this issue

2025-11-02 12:19:41 -06:00

[PR #3169] [MERGED] Fix source download link when no code unit allowed (#3166) #16813

Sign in to join this conversation.