Pull Request button on the pulls page does not behave the same as on the repo files page #3140

New Issue

GiteaMirror · 2025-11-02T05:01:51-06:00

GiteaMirror commented

2025-11-02 05:01:51 -06:00

Originally created by @richmahn on GitHub (Apr 4, 2019).

Signaling intent to fix an issue we have been bothered by, where the link of the "New Pull Request" button on the Pull Request page of the upstream (main) repo will have the name of the user if the user has a fork of the repo. This should only happen if the user is on the Pull Request page of a fork, not all the time.

For example, user1 has repo1. user2 forks repo1 and thus has their own repo1. Go to user1/repo1's home page (file listing) and the "New Pull Request" button will be correct (http://localhost:3000/user1/repo1/compare/master...master)

but if you go to the "Pull Requests" page, the link of the "New Pull Request" button is http://localhost:3000/user1/repo1/compare/master...user2:repo1

This is not the desired use, nor like how GitHub works, as a user may very well be wanting to make a pull request from a branch of the current repo to the same repo (not from his/her repo). Users have to edit the URL themselves, and most of our users don't understand that.

Originally created by @richmahn on GitHub (Apr 4, 2019). Signaling intent to fix an issue we have been bothered by, where the link of the "New Pull Request" button on the Pull Request page of the upstream (main) repo will have the name of the user if the user has a fork of the repo. This should only happen if the user is on the Pull Request page of a fork, not all the time. For example, user1 has repo1. user2 forks repo1 and thus has their own repo1. Go to user1/repo1's home page (file listing) and the "New Pull Request" button will be correct (http://localhost:3000/user1/repo1/compare/master...master) <img width="457" alt="Screen Shot 2019-04-04 at 4 01 04 PM" src="https://user-images.githubusercontent.com/2839925/55591787-c09bfa00-56f3-11e9-80d2-4d09787b3f3e.png"> but if you go to the "Pull Requests" page, the link of the "New Pull Request" button is http://localhost:3000/user1/repo1/compare/master...user2:repo1 <img width="782" alt="Screen Shot 2019-04-04 at 4 05 48 PM" src="https://user-images.githubusercontent.com/2839925/55591807-cdb8e900-56f3-11e9-8787-6cacfabfe033.png"> This is not the desired use, nor like how GitHub works, as a user may very well be wanting to make a pull request from a branch of the current repo to the same repo (not from his/her repo). Users have to edit the URL themselves, and most of our users don't understand that.

GiteaMirror added the type/enhancement label 2025-11-02 05:01:51 -06:00

GiteaMirror closed this issue

2025-11-02 05:01:51 -06:00

GiteaMirror referenced this issue

2025-11-02 12:19:10 -06:00

[PR #3140] [MERGED] Fixtures for public_key table #16790

Sign in to join this conversation.