Corrupted indentation in "Files Changed" section of a pull request #3130

New Issue

GiteaMirror · 2025-11-02T05:01:33-06:00

GiteaMirror commented

2025-11-02 05:01:33 -06:00

Originally created by @gavlig on GitHub (Apr 2, 2019).

Gitea version (or commit ref): cd8cdbd
Git version: 2.21 on client (don't know what's on try.gitea but it's irrelevant)
Operating system: linux
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (https://try.gitea.io/gavlig/indent_bug/pulls/1/files)
- No
- Not relevant
Log gist:

Description

Diff viewer(Files Changed) for pull requests corrupts indentation with "+-" signs. I don't know what would be a proper fix for this, but just removing them already solves the issue for me. I guess those can be added in the same column where the line numbers are. If that's an acceptable change i could make a PR for that

Screenshots

Here i manually removed "+" signs for the code to become aligned

Originally created by @gavlig on GitHub (Apr 2, 2019). - Gitea version (or commit ref): cd8cdbd - Git version: 2.21 on client (don't know what's on try.gitea but it's irrelevant) - Operating system: linux - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (https://try.gitea.io/gavlig/indent_bug/pulls/1/files) - [ ] No - [ ] Not relevant - Log gist: ## Description Diff viewer(Files Changed) for pull requests corrupts indentation with "+-" signs. I don't know what would be a proper fix for this, but just removing them already solves the issue for me. I guess those can be added in the same column where the line numbers are. If that's an acceptable change i could make a PR for that ## Screenshots ![Screenshot from 2019-04-02 18-42-00](https://user-images.githubusercontent.com/668981/55420350-1bf4ad80-5577-11e9-9ecc-d146750b8f27.png) Here i manually removed "+" signs for the code to become aligned ![Screenshot from 2019-04-02 18-42-26](https://user-images.githubusercontent.com/668981/55420354-1f883480-5577-11e9-8155-dd5b62b2a015.png)

GiteaMirror added the issue/stale label 2025-11-02 05:01:33 -06:00

GiteaMirror closed this issue

2025-11-02 05:01:34 -06:00

GiteaMirror commented

2025-11-02 05:01:34 -06:00

@lafriks commented on GitHub (Apr 8, 2019):

Viewing file also does ident same as in diff: eb951aee84/main.cpp

@lafriks commented on GitHub (Apr 8, 2019): Viewing file also does ident same as in diff: https://try.gitea.io/gavlig/indent_bug/src/commit/eb951aee841acd700b2d51a6c296e592c1dedb34/main.cpp

GiteaMirror commented

2025-11-02 05:01:35 -06:00

@gavlig commented on GitHub (Apr 9, 2019):

yes, that's true now, i guess i missed something, i'll investigate this, because it used to work, but i might've been looking on my fixed version

@gavlig commented on GitHub (Apr 9, 2019): yes, that's true now, i guess i missed something, i'll investigate this, because it used to work, but i might've been looking on my fixed version

GiteaMirror commented

2025-11-02 05:01:35 -06:00

@gavlig commented on GitHub (Apr 9, 2019):

So the reason it's still indented is this issue: https://github.com/go-gitea/gitea/issues/5596
but it's a different bug

@gavlig commented on GitHub (Apr 9, 2019): So the reason it's still indented is this issue: https://github.com/go-gitea/gitea/issues/5596 but it's a different bug

GiteaMirror commented

2025-11-02 05:01:35 -06:00

@stale[bot] commented on GitHub (Jun 8, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jun 8, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 05:01:35 -06:00

@stale[bot] commented on GitHub (Jun 22, 2019):

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale[bot] commented on GitHub (Jun 22, 2019): This issue has been automatically closed because of inactivity. You can re-open it if needed.

GiteaMirror referenced this issue

2025-11-02 12:19:03 -06:00

[PR #3130] [MERGED] Fix compile failed without gcc #16784

Sign in to join this conversation.