webhook compare_url is not filled in #3107

New Issue

GiteaMirror · 2025-11-02T05:00:59-06:00

GiteaMirror commented

2025-11-02 05:00:59 -06:00

Originally created by @luvarqpp on GitHub (Mar 27, 2019).

Gitea version (or commit ref): 1.7.4
Git version: 2.16.5
Operating system: Centos 7
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL): https://try.gitea.io/lubomir.varga/pushtest/settings/hooks/181
- No
- Not relevant
Log gist:

Description

Short: In POST request there is field "compare_url", which is not filled in.
parsing "compare_url"

Long desc

I have installed gitea server together with jenkins instance and I have installed gitea plugin for jenkins. Than I have set-up single jenkins job (gitea organization). It have found some repositories and created multibranch job for them. Also webhooks in gitea was set-up by jenkins plugin automatically (as it was requested in jenkins plugin settings).

Disclaimer: I have not studied gitea jenkins plugin deeply, I have just done some basic "grep" for some keywords.

It seems that webhooks are working and I see that delivery was successful (http 200 response with body: "Processed"). There is no trigerred jenkins builds through. I have find out that jenkins plugin is parsing "compare_url" from data. Given attribute is set to be empty string, so I think that this is root of my problem.

Another source code is suggesting that match is done using html url.

Originally created by @luvarqpp on GitHub (Mar 27, 2019).   - Gitea version (or commit ref): 1.7.4 - Git version: 2.16.5 - Operating system: Centos 7 - Database (use `[x]`): - [X] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [X] Yes (provide example URL): https://try.gitea.io/lubomir.varga/pushtest/settings/hooks/181 - [ ] No - [ ] Not relevant - Log gist: ## Description Short: In POST request there is field "compare_url", which is not filled in. parsing "compare_url" ### Long desc I have installed gitea server together with jenkins instance and I have installed gitea plugin for jenkins. Than I have set-up single jenkins job (gitea organization). It have found some repositories and created multibranch job for them. Also webhooks in gitea was set-up by jenkins plugin automatically (as it was requested in jenkins plugin settings). Disclaimer: I have not studied gitea jenkins plugin deeply, I have just done some basic "grep" for some keywords. It seems that webhooks are working and I see that delivery was successful (http 200 response with body: "Processed"). There is no trigerred jenkins builds through. I have find out that jenkins plugin is [parsing "compare_url"](https://github.com/jenkinsci/gitea-plugin/blob/master/src/main/java/org/jenkinsci/plugin/gitea/client/api/GiteaPushEvent.java#L90) from data. Given attribute is set to be empty string, so I think that this is root of my problem. Another source code is suggesting that [match is done using html url](https://github.com/jenkinsci/gitea-plugin/blob/master/src/main/java/org/jenkinsci/plugin/gitea/GiteaPushSCMEvent.java#L134).

GiteaMirror added the issue/confirmed type/enhancement labels 2025-11-02 05:00:59 -06:00

GiteaMirror commented

2025-11-02 05:01:00 -06:00

@stale[bot] commented on GitHub (May 26, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (May 26, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror referenced this issue

2025-11-02 12:18:42 -06:00

[PR #3107] [MERGED] Fix repo indexer and submodule bug #16770

GiteaMirror referenced this issue

2025-11-02 12:18:47 -06:00

[PR #3110] [MERGED] Fix repo indexer and submodule bug (#3107) #16773

Sign in to join this conversation.