Fix linting error #31

New Issue

GiteaMirror · 2025-11-02T03:05:01-06:00

GiteaMirror commented

2025-11-02 03:05:01 -06:00

Originally created by @tboerger on GitHub (Nov 4, 2016).

Currently the go linter errors out on various places, we should fix that to increase the code quality.

Originally created by @tboerger on GitHub (Nov 4, 2016). Currently the go linter errors out on various places, we should fix that to increase the code quality.

GiteaMirror added the type/enhancement label 2025-11-02 03:05:01 -06:00

GiteaMirror closed this issue

2025-11-02 03:05:01 -06:00

GiteaMirror commented

2025-11-02 03:05:02 -06:00

@DblK commented on GitHub (Nov 4, 2016):

Do you would like to have a huge PR or smaller PR by folder for example?
I saw on lint it misses several comments for each function.

Tell me what you want.

@DblK commented on GitHub (Nov 4, 2016): Do you would like to have a huge PR or smaller PR by folder for example? I saw on lint it misses several comments for each function. Tell me what you want.

GiteaMirror commented

2025-11-02 03:05:02 -06:00

@xinity commented on GitHub (Nov 4, 2016):

@DblK smaller PR are easier to review :)

so i'd vote for smaller ones

@xinity commented on GitHub (Nov 4, 2016): @DblK smaller PR are easier to review :) so i'd vote for smaller ones

GiteaMirror commented

2025-11-02 03:05:02 -06:00

@tboerger commented on GitHub (Nov 4, 2016):

👍 for smaller prs, as @xinity said it's better to review

@tboerger commented on GitHub (Nov 4, 2016): :+1: for smaller prs, as @xinity said it's better to review

GiteaMirror commented

2025-11-02 03:05:02 -06:00

@tboerger commented on GitHub (Nov 4, 2016):

But continue with the models, I already started parts within the makefile pr

@tboerger commented on GitHub (Nov 4, 2016): But continue with the models, I already started parts within the makefile pr

GiteaMirror commented

2025-11-02 03:05:02 -06:00

@lunny commented on GitHub (Nov 29, 2016):

Only modules/bindata/bindata.go not be fixed. But that file is generated by go-bindata. Any idea? @tboerger

@lunny commented on GitHub (Nov 29, 2016): Only `modules/bindata/bindata.go` not be fixed. But that file is generated by go-bindata. Any idea? @tboerger

GiteaMirror commented

2025-11-02 03:05:03 -06:00

@tboerger commented on GitHub (Nov 29, 2016):

Switch to a proper bindata tool like fileb0x (but it doesn't support tags) or go.rice or somehow ignore it

@tboerger commented on GitHub (Nov 29, 2016): Switch to a proper bindata tool like fileb0x (but it doesn't support tags) or go.rice or somehow ignore it

GiteaMirror commented

2025-11-02 03:05:03 -06:00

@tboerger commented on GitHub (Nov 29, 2016):

On the other side, we will drop the bindata from the repo soon, than it's not part of the repo anymore

@tboerger commented on GitHub (Nov 29, 2016): On the other side, we will drop the bindata from the repo soon, than it's not part of the repo anymore

GiteaMirror commented

2025-11-02 03:05:03 -06:00

@lunny commented on GitHub (Nov 29, 2016):

But maybe we can ingore the golint check on Makefile at first. So that we an close this issue and ask all the PR to pass the golint.

@lunny commented on GitHub (Nov 29, 2016): But maybe we can ingore the golint check on Makefile at first. So that we an close this issue and ask all the PR to pass the golint.

GiteaMirror commented

2025-11-02 03:05:03 -06:00

@tboerger commented on GitHub (Nov 29, 2016):

Maybe you can filter out the bindata package from the list temporary? Like grep -v

@tboerger commented on GitHub (Nov 29, 2016): Maybe you can filter out the bindata package from the list temporary? Like grep -v

GiteaMirror commented

2025-11-02 03:05:03 -06:00

@strk commented on GitHub (Nov 29, 2016):

@lunny if you find out how to ignore a single file, I'm all for going with it, especially as after a "make" invocation you'd have the bindata.go around and it might be annoying to get those false positives

@strk commented on GitHub (Nov 29, 2016): @lunny if you find out how to ignore a single file, I'm all for going with it, especially as after a "make" invocation you'd have the bindata.go around and it might be annoying to get those false positives

GiteaMirror commented

2025-11-02 03:05:04 -06:00

@tboerger commented on GitHub (Nov 29, 2016):

On the short term we can simply ignore the entire code.gitea.io/gitea/modules/bindata package.

@tboerger commented on GitHub (Nov 29, 2016): On the short term we can simply ignore the entire `code.gitea.io/gitea/modules/bindata` package.

GiteaMirror commented

2025-11-02 03:05:04 -06:00

@lunny commented on GitHub (Nov 29, 2016):

So this could be closed via #303

@lunny commented on GitHub (Nov 29, 2016): So this could be closed via #303

GiteaMirror referenced this issue

2025-11-02 03:07:06 -06:00