github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-15 20:09:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[Feature request] Pull requests: Lazy loading for diffs #3076

New Issue
Closed
opened 2025-11-02 04:59:58 -06:00 by GiteaMirror · 10 comments
GiteaMirror commented 2025-11-02 04:59:58 -06:00
Owner
Copy Link

Originally created by @3l73 on GitHub (Mar 19, 2019).

Gitea: 1.7

Current situation:
If the amount of changed files reached a specific count, gitea shows the message that more files changed.
It is not possible to which files are affected.

This behaviour may a result of performance and memory issues.

Idea:
If the amount of files reach a specific count, all affected files are displayed collapsed. The user had to click on a specific file to see the difference.

Originally created by @3l73 on GitHub (Mar 19, 2019). Gitea: 1.7 Current situation: If the amount of changed files reached a specific count, gitea shows the message that more files changed. It is not possible to which files are affected. This behaviour may a result of performance and memory issues. Idea: If the amount of files reach a specific count, all affected files are displayed collapsed. The user had to click on a specific file to see the difference.
GiteaMirror added the issue/confirmedtype/enhancement labels 2025-11-02 04:59:58 -06:00
GiteaMirror commented 2025-11-02 04:59:59 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (May 19, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (May 19, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.
GiteaMirror commented 2025-11-02 04:59:59 -06:00
Author
Owner
Copy Link

@kdumontnu commented on GitHub (Jul 12, 2021):

This would be a great feature to work on for v1.16

@kdumontnu commented on GitHub (Jul 12, 2021): This would be a great feature to work on for `v1.16`
GiteaMirror commented 2025-11-02 04:59:59 -06:00
Author
Owner
Copy Link

@delvh commented on GitHub (Nov 19, 2021):

Fixed in #16829?

@delvh commented on GitHub (Nov 19, 2021): Fixed in #16829?
GiteaMirror commented 2025-11-02 04:59:59 -06:00
Author
Owner
Copy Link

@jpraet commented on GitHub (Nov 19, 2021):

I'm trying it out but it's not working for me: https://try.gitea.io/jpraet-org/test-repo/pulls/1/files
When clicking "Show More" I see this error in the console:
XHR GET https://try.gitea.io/jpraet-org/test-repo/pulls/1/files?skip-to=101.txt&file-only=true
[HTTP/2 500 Internal Server Error 190ms]

@jpraet commented on GitHub (Nov 19, 2021): I'm trying it out but it's not working for me: https://try.gitea.io/jpraet-org/test-repo/pulls/1/files When clicking "Show More" I see this error in the console: XHR GET https://try.gitea.io/jpraet-org/test-repo/pulls/1/files?skip-to=101.txt&file-only=true [HTTP/2 500 Internal Server Error 190ms]
GiteaMirror commented 2025-11-02 04:59:59 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Nov 19, 2021):

@jpraet please open new issues instead of commenting on old ones and give us logs for what went wrong.

@zeripath commented on GitHub (Nov 19, 2021): @jpraet please open new issues instead of commenting on old ones and give us logs for what went wrong.
GiteaMirror commented 2025-11-02 05:00:00 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Nov 19, 2021):

I cannot reproduce this locally therefore I need the logs.

@zeripath commented on GitHub (Nov 19, 2021): I cannot reproduce this locally therefore I need the logs.
GiteaMirror commented 2025-11-02 05:00:00 -06:00
Author
Owner
Copy Link

@jpraet commented on GitHub (Nov 19, 2021):

I'll open another ticket, but in the meantime, here's the log output when reproducing it locally:

2021/11/19 21:30:27 Started GET /jpraet/test/pulls/33/files?skip-to=101.txt&file-only=true for 127.0.0.1:54238
usage: git diff [<options>] [<commit> [<commit>]] [--] [<path>...]
2021/11/19 21:30:28 ...ers/web/repo/pull.go:641:ViewPullFiles() [E] GetDiffRangeWithWhitespaceBehavior: Wait: exit status 129
2021/11/19 21:30:28 ...s/gitdiff/gitdiff.go:1328:func1() [E] Unable to open checker for 3ce2ba0f0b457f8407c698581e1fc05f42dda2d7. Error: failed to run attr-check. Error: exit status 1
        Stderr:
2021/11/19 21:30:28 Completed GET /jpraet/test/pulls/33/files?skip-to=101.txt&file-only=true 500 Internal Server Error in 727.5449ms

I don't think the "Unable to open checker" error is the actual problem, as I also see that error when just opening the files tab on the PR. That one seems like a non-blocking error (that maybe should be looked into nonetheless?).

@jpraet commented on GitHub (Nov 19, 2021): I'll open another ticket, but in the meantime, here's the log output when reproducing it locally: ``` 2021/11/19 21:30:27 Started GET /jpraet/test/pulls/33/files?skip-to=101.txt&file-only=true for 127.0.0.1:54238 usage: git diff [<options>] [<commit> [<commit>]] [--] [<path>...] 2021/11/19 21:30:28 ...ers/web/repo/pull.go:641:ViewPullFiles() [E] GetDiffRangeWithWhitespaceBehavior: Wait: exit status 129 2021/11/19 21:30:28 ...s/gitdiff/gitdiff.go:1328:func1() [E] Unable to open checker for 3ce2ba0f0b457f8407c698581e1fc05f42dda2d7. Error: failed to run attr-check. Error: exit status 1 Stderr: 2021/11/19 21:30:28 Completed GET /jpraet/test/pulls/33/files?skip-to=101.txt&file-only=true 500 Internal Server Error in 727.5449ms ``` I don't think the "Unable to open checker" error is the actual problem, as I also see that error when just opening the files tab on the PR. That one seems like a non-blocking error (that maybe should be looked into nonetheless?).
GiteaMirror commented 2025-11-02 05:00:00 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Nov 19, 2021):

What version of git do you have?

@zeripath commented on GitHub (Nov 19, 2021): What version of git do you have?
GiteaMirror commented 2025-11-02 05:00:00 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Nov 19, 2021):

damn I misread the git documentation - it looks like skip-to only appeared in git 2.31!!

@zeripath commented on GitHub (Nov 19, 2021): damn I misread the git documentation - it looks like skip-to only appeared in git 2.31!!
GiteaMirror commented 2025-11-02 05:00:01 -06:00
Author
Owner
Copy Link

@jpraet commented on GitHub (Nov 19, 2021):

Bug report created: #17731

I'm using quite an old git version 2.18 on this machine. try.gitea.io is also on an older version then?

@jpraet commented on GitHub (Nov 19, 2021): Bug report created: #17731 I'm using quite an old git version 2.18 on this machine. try.gitea.io is also on an older version then?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#3076
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?