[feature request - ui tweak] ssh key adding form UI usability #3037

New Issue

GiteaMirror · 2025-11-02T04:58:16-06:00

GiteaMirror commented

2025-11-02 04:58:16 -06:00

Originally created by @mateusza on GitHub (Mar 10, 2019).

Description

When adding new SSH key, key title should be automatically populated from public key comment field.

Additionally, in my personal opinion, swapping order of these two fields (making the key content textarea go above the title) would make it more intuitive. I often just paste the key into the first field available before realizing it's the "title" and the key should go into the other one.

The JS code:

var $sshKeyContent = $('#ssh-key-content')
$sshKeyContent.change(function() {
	var $sshKeyTitle = $('#ssh-key-title');
	if ( $sshKeyContent.val().length > 0 && $sshKeyTitle.val() === "" ){
		$sshKeyTitle.val( $sshKeyContent.val().trimRight().match( /^ssh-[^ ]* [^ ]* (.*)$/ )[1] );
	}
} );

Screenshots

Originally created by @mateusza on GitHub (Mar 10, 2019). ## Description When adding new SSH key, key title should be automatically populated from public key comment field. Additionally, in my personal opinion, swapping order of these two fields (making the key content textarea go above the title) would make it more intuitive. I often just paste the key into the first field available before realizing it's the "title" and the key should go into the other one. The JS code: ``` var $sshKeyContent = $('#ssh-key-content') $sshKeyContent.change(function() { var $sshKeyTitle = $('#ssh-key-title'); if ( $sshKeyContent.val().length > 0 && $sshKeyTitle.val() === "" ){ $sshKeyTitle.val( $sshKeyContent.val().trimRight().match( /^ssh-[^ ]* [^ ]* (.*)$/ )[1] ); } } ); ``` ## Screenshots  ![image](https://user-images.githubusercontent.com/7002/54085765-cb0be380-4341-11e9-85fd-c2de68481b48.png)

GiteaMirror added the type/enhancement issue/stale labels 2025-11-02 04:58:16 -06:00

GiteaMirror closed this issue

2025-11-02 04:58:16 -06:00

GiteaMirror commented

2025-11-02 04:58:17 -06:00

@lunny commented on GitHub (Mar 11, 2019):

Please send a PR to fix that.

@lunny commented on GitHub (Mar 11, 2019): Please send a PR to fix that.

GiteaMirror commented

2025-11-02 04:58:18 -06:00

@mateusza commented on GitHub (Mar 15, 2019):

I just noticed this was already implemented 2 YEARS AGO in #950 but it only works when the key comment does not contain any spaces. I will fix that.

@mateusza commented on GitHub (Mar 15, 2019): I just noticed this was already implemented 2 YEARS AGO in #950 but it only works when the key comment does not contain any spaces. I will fix that.

GiteaMirror commented

2025-11-02 04:58:18 -06:00

@Piraty commented on GitHub (Mar 18, 2019):

please don't swap the textboxes. Since their purpose is clearly stated, it makes sense they way it is. And yes, the comment is inserted automatically into the "key name" field

@Piraty commented on GitHub (Mar 18, 2019): please don't swap the textboxes. Since their purpose is clearly stated, it makes sense they way it is. And yes, the comment is inserted automatically into the "key name" field

GiteaMirror commented

2025-11-02 04:58:18 -06:00

@stale[bot] commented on GitHub (May 17, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (May 17, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 04:58:18 -06:00

@lunny commented on GitHub (May 19, 2019):

This has been resolved.

@lunny commented on GitHub (May 19, 2019): This has been resolved.

GiteaMirror referenced this issue

2025-11-02 12:17:32 -06:00

[PR #3037] [MERGED] Remove duplicated sanitize #16727

Sign in to join this conversation.