Terminate option parsing in Git Commands prior to passing refspecs #3036

New Issue

GiteaMirror · 2025-11-02T04:58:13-06:00

GiteaMirror commented

2025-11-02 04:58:13 -06:00

Originally created by @zeripath on GitHub (Mar 10, 2019).

Gitea version (or commit ref): master
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL) https://try.gitea.io/arandomer/test-perry123/commits/branch/--heads/testfile
- No
- Not relevant
Log gist:

Description

Throughout Gitea there are multiple places where there is use of git.NewCommand, or the like, where an argument is passed in to this command that could potentially be misinterpreted as an option. These should be protected through use of the "--" argument to terminate option parsing.

Originally created by @zeripath on GitHub (Mar 10, 2019). - Gitea version (or commit ref): master - Can you reproduce the bug at https://try.gitea.io: - [X] Yes (provide example URL) https://try.gitea.io/arandomer/test-perry123/commits/branch/--heads/testfile - [ ] No - [ ] Not relevant - Log gist: ## Description Throughout Gitea there are multiple places where there is use of `git.NewCommand`, or the like, where an argument is passed in to this command that could potentially be misinterpreted as an option. These should be protected through use of the `"--"` argument to terminate option parsing.

GiteaMirror added the type/enhancement issue/stale labels 2025-11-02 04:58:13 -06:00

GiteaMirror closed this issue

2025-11-02 04:58:14 -06:00

GiteaMirror commented

2025-11-02 04:58:15 -06:00

@stale[bot] commented on GitHub (May 11, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (May 11, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 04:58:15 -06:00

@stale[bot] commented on GitHub (May 25, 2019):

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale[bot] commented on GitHub (May 25, 2019): This issue has been automatically closed because of inactivity. You can re-open it if needed.

GiteaMirror referenced this issue

2025-11-02 12:17:35 -06:00

[PR #3039] [MERGED] Fix missing password length check when change password #16729

Sign in to join this conversation.