--name and --username consistency issue in CLI #2968

New Issue

GiteaMirror · 2025-11-02T04:55:33-06:00

GiteaMirror commented

2025-11-02 04:55:33 -06:00

Originally created by @ghost on GitHub (Feb 24, 2019).

Gitea version (or commit ref): 1.7
Can you reproduce the bug at https://try.gitea.io:
- Not relevant

Description

In create-user --name is used, but in change-password --username is used instead.

Originally created by @ghost on GitHub (Feb 24, 2019). - Gitea version (or commit ref): 1.7 - Can you reproduce the bug at https://try.gitea.io: - [x] Not relevant ## Description In create-user --name is used, but in change-password --username is used instead.

GiteaMirror added the type/proposal type/enhancement labels 2025-11-02 04:55:33 -06:00

GiteaMirror closed this issue

2025-11-02 04:55:34 -06:00

GiteaMirror commented

2025-11-02 04:55:35 -06:00

@ngourdon commented on GitHub (Apr 6, 2019):

Which one should we keep ?
I think "--name" is better. We know we're talking about user in these commands.

We should keep both parameters to ensure backward compatibility for a while.

I can contribute on this if we're OK.

@ngourdon commented on GitHub (Apr 6, 2019): Which one should we keep ? I think "--name" is better. We know we're talking about user in these commands. We should keep both parameters to ensure backward compatibility for a while. I can contribute on this if we're OK.

GiteaMirror commented

2025-11-02 04:55:35 -06:00

@mrsdizzie commented on GitHub (Apr 6, 2019):

I think this should always be --username when referring to the actual username

username is a term with a specific meaning (the username), where as name is not.

Also, an account has both a username and then a separate name/full name field so it should always use the phrase username when referring to the actual username (which this case is).

@mrsdizzie commented on GitHub (Apr 6, 2019): I think this should always be --username when referring to the actual username username is a term with a specific meaning (the username), where as name is not. Also, an account has both a username and then a separate name/full name field so it should always use the phrase username when referring to the actual username (which this case is).

GiteaMirror referenced this issue

2025-11-02 12:21:46 -06:00

[PR #3354] [MERGED] Rework special link parsing in the post-processing of markup #16903

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#2968