github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-06 02:02:32 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Attachment ALLOWED_TYPE being ignored? #294

New Issue
Closed
opened 2025-11-02 03:17:34 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-02 03:17:34 -06:00
Owner
Copy Link

Originally created by @esell on GitHub (Jan 27, 2017).

  • Gitea version (or commit ref): e08421017c
  • Git version: 2.7.4
  • Operating system: Ubuntu Linux (xenial)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

It appears that the ALLOWED_TYPE config attribute is not being honored. I looked inside of modules/setting/setting.go and it appears that this value is being hard coded, is that true?

AttachmentAllowedTypes = strings.Replace(sec.Key("ALLOWED_TYPES").MustString("image/jpeg,image/png,application/zip,application/gzip"), "|", ",", -1)

I'm not sure what that MustString function is (xorm related) but it appears that the MIME list is being fed in directly via the code and not the actual config attribute. Am I reading that wrong?
...

Originally created by @esell on GitHub (Jan 27, 2017). - Gitea version (or commit ref): e08421017c50d881710f52c9fd942239a4a928ae - Git version: 2.7.4 - Operating system: Ubuntu Linux (xenial) - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [X] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [X] Not relevant - Log gist: ## Description It appears that the `ALLOWED_TYPE` config attribute is not being honored. I looked inside of `modules/setting/setting.go` and it appears that this value is being hard coded, is that true? AttachmentAllowedTypes = strings.Replace(sec.Key("ALLOWED_TYPES").MustString("image/jpeg,image/png,application/zip,application/gzip"), "|", ",", -1) I'm not sure what that `MustString` function is (xorm related) but it appears that the MIME list is being fed in directly via the code and not the actual config attribute. Am I reading that wrong? ...
GiteaMirror added the issue/not-a-bug label 2025-11-02 03:17:34 -06:00
GiteaMirror commented 2025-11-02 03:17:35 -06:00
Author
Owner
Copy Link

@esell commented on GitHub (Jan 27, 2017):

NM

@esell commented on GitHub (Jan 27, 2017): NM
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/not-a-bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#294
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?