github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 13:20:06 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Incorrect logging formatting #292

New Issue
Closed
opened 2025-11-02 03:17:30 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 03:17:30 -06:00
Owner
Copy Link

Originally created by @gabrieljackson on GitHub (Jan 27, 2017).

  • Gitea version (or commit ref): 25663b5816
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

I searched and didn't see this issue noted anywhere so I figured I would open a new one.

Currently, the logging code is often formatted to output something like "we ran into an error: %v", err, but is then passed to something like log.Fatal(). This leads to incorrect formatting when the log is written.

Example: https://github.com/go-gitea/gitea/blob/master/cmd/web_graceful.go#L36

2017/01/27 15:11:22 4Failed to load https cert file %s: %v0.0.0.0:3000open /data/key.pem: permission denied

I have started a local branch to convert many of the log calls from log.Fatal to log.Fatalf or similar and would be happy to open a PR for it.

Edit: fixed a bunch of typos in the original issue description.

Originally created by @gabrieljackson on GitHub (Jan 27, 2017). - Gitea version (or commit ref): 25663b58161c48bdc8e9cae900544378dede0d2b - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant ## Description I searched and didn't see this issue noted anywhere so I figured I would open a new one. Currently, the logging code is often formatted to output something like `"we ran into an error: %v", err`, but is then passed to something like `log.Fatal()`. This leads to incorrect formatting when the log is written. Example: https://github.com/go-gitea/gitea/blob/master/cmd/web_graceful.go#L36 ``` 2017/01/27 15:11:22 4Failed to load https cert file %s: %v0.0.0.0:3000open /data/key.pem: permission denied ``` I have started a local branch to convert many of the log calls from `log.Fatal` to `log.Fatalf` or similar and would be happy to open a PR for it. Edit: fixed a bunch of typos in the original issue description.
GiteaMirror added the type/enhancement label 2025-11-02 03:17:30 -06:00
GiteaMirror commented 2025-11-02 03:17:31 -06:00
Author
Owner
Copy Link

@bkcsoft commented on GitHub (Jan 28, 2017):

would be happy to open a PR for it.

Please do 🙂

@bkcsoft commented on GitHub (Jan 28, 2017): > would be happy to open a PR for it. Please do 🙂
GiteaMirror commented 2025-11-02 03:17:31 -06:00
Author
Owner
Copy Link

@tboerger commented on GitHub (Feb 10, 2017):

I would say it's done so far. If you think there are various other places that needs to be fixed feel free to reopen this issue.

@tboerger commented on GitHub (Feb 10, 2017): I would say it's done so far. If you think there are various other places that needs to be fixed feel free to reopen this issue.
GiteaMirror commented 2025-11-02 03:17:31 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Feb 10, 2017):

lost

@lunny commented on GitHub (Feb 10, 2017): lost
GiteaMirror commented 2025-11-02 03:17:31 -06:00
Author
Owner
Copy Link

@tboerger commented on GitHub (Feb 10, 2017):

lost

What do you mean?

@tboerger commented on GitHub (Feb 10, 2017): > lost What do you mean?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#292
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?